bug#23063: closed (24.5; Multi-line sql statements are not saved correctly)

[GNU bug Tracking System]

Your message dated Tue, 11 Aug 2020 20:23:09 -0700
with message-id 
<CADwFkmmNAht3ZROtfbveTbNQwbqfudO8LabyzM57PCMTD01ihA@mail.gmail.com>
and subject line Re: bug#23063: 24.5; Multi-line sql statements are not saved 
correctly
has caused the debbugs.gnu.org bug report #23063,
regarding 24.5; Multi-line sql statements are not saved correctly
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
23063: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23063
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 24.5; Multi-line sql statements are not saved correctly Date: Sat, 19 Mar 2016 18:10:33 +0300 User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0

Currently comint.el does not respect local values of comint-input-ring-separator. Sql mode on the other hand sets it locally. This prevents multi-line sql history from working.

Sql history is stored using comint-write-input-ring. When it saves the history file, it uses with-current-buffer, thus ignoring previous local value. When read comint-read-input-ring uses with-temp-buffer with similar results.

This seems to have been caused by the fix for this bug.

-- 
Best Regards,
Nikolay Kudryavtsev

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#23063: 24.5; Multi-line sql statements are not saved correctly
>
>
>
>
> Date: 
>
> Tue, 11 Aug 2020 20:23:09 -0700
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
>
>
>
>
> Stefan Kangas <stefan@marxist.se> writes:
>
> > Hi Michael,
> >
> > Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com> writes:
> >
> >> Currently comint.el does not respect local values of 
> >> comint-input-ring-separator. Sql mode on the other hand sets it locally. 
> >> This prevents multi-line sql history from working.
> >>
> >> Sql history is stored using comint-write-input-ring. When it saves the 
> >> history file, it uses with-current-buffer, thus ignoring previous local 
> >> value. When read comint-read-input-ring uses with-temp-buffer with similar 
> >> results.
> >>
> >> This seems to have been caused by the fix for this bug.
> >
> > This bug was tagged as "unreproducible moreinfo" in a message to
> > control@debbugs called "Close bugs" sent on 21 Apr 2019, but the bug
> > itself was never closed.
> >
> > Should the bug be closed as well?
>
> No reply here within 14 weeks.  I'm going to assume the intention here
> was to close this bug, so I'm doing that now.
>
> If this conclusion is incorrect, please reply to this email (use "Reply
> to all" in your email client) and we can reopen the bug report.
>
> Best regards,
> Stefan Kangas
>
>
> --- End Message ---