bug#42702: closed (catch2 fails to build on non x86_64 systems)

[GNU bug Tracking System]

Your message dated Tue, 4 Aug 2020 10:44:32 +0300
with message-id <20200804074432.GN1134@E5400>
and subject line Re: bug#42702: catch2 build failure on ARM
has caused the debbugs.gnu.org bug report #42702,
regarding catch2 fails to build on non x86_64 systems
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
42702: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42702
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> catch2 build failure on ARM
>
>
>
>
> Date: 
>
> Mon, 03 Aug 2020 14:22:21 -0400
>
>
>
>
> On ARM systems, (armhf-linux, aarch64-linux), the catch2 package fails to 
> build, due to a
> compilation warning treated as an error:
>
> [ 90%] Building CXX object 
> CMakeFiles/SelfTest.dir/include/reporters/catch_reporter_xml.cpp.o
> /gnu/store/ap7hgyv4rjqmhg4a6cb6cypsh3g1f5q4-gcc-7.5.0/bin/c++   
> -I/tmp/guix-build-catch2-2.1.2.drv-0/source/include  -O2 -g -DNDEBUG   -Wall 
> -Wextra -Wunreachable-code -Wpedantic -Werror -std=c++11 -o 
> CMakeFiles/SelfTest.dir/include/reporters/catch_reporter_xml.cpp.o -c 
> /tmp/guix-build-catch2-2.1.2.drv-0/source/include/reporters/catch_reporter_xml.cpp
> /tmp/guix-build-catch2-2.1.2.drv-0/source/include/internal/catch_tostring.cpp: 
> In static member function ‘static std::__cxx11::string 
> Catch::StringMaker<char>::convert(char)’:
> /tmp/guix-build-catch2-2.1.2.drv-0/source/include/internal/catch_tostring.cpp:202:21:
>  error: comparison is always true due to limited range of data type 
> [-Werror=type-limits]
>      } else if ('\0' <= value && value < ' ') {
>                 ~~~~~^~~~~~~~
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#42702: catch2 build failure on ARM Date: Tue, 4 Aug 2020 10:44:32 +0300

On Mon, Aug 03, 2020 at 02:22:21PM -0400, maxim.cournoyer@gmail.com wrote:
> On ARM systems, (armhf-linux, aarch64-linux), the catch2 package fails to 
> build, due to a
> compilation warning treated as an error:
> 
> [ 90%] Building CXX object 
> CMakeFiles/SelfTest.dir/include/reporters/catch_reporter_xml.cpp.o
> /gnu/store/ap7hgyv4rjqmhg4a6cb6cypsh3g1f5q4-gcc-7.5.0/bin/c++   
> -I/tmp/guix-build-catch2-2.1.2.drv-0/source/include  -O2 -g -DNDEBUG   -Wall 
> -Wextra -Wunreachable-code -Wpedantic -Werror -std=c++11 -o 
> CMakeFiles/SelfTest.dir/include/reporters/catch_reporter_xml.cpp.o -c 
> /tmp/guix-build-catch2-2.1.2.drv-0/source/include/reporters/catch_reporter_xml.cpp
> /tmp/guix-build-catch2-2.1.2.drv-0/source/include/internal/catch_tostring.cpp:
>  In static member function ‘static std::__cxx11::string 
> Catch::StringMaker<char>::convert(char)’:
> /tmp/guix-build-catch2-2.1.2.drv-0/source/include/internal/catch_tostring.cpp:202:21:
>  error: comparison is always true due to limited range of data type 
> [-Werror=type-limits]
>      } else if ('\0' <= value && value < ' ') {
>                 ~~~~~^~~~~~~~

Fixed in 7f101e7ceb869882b9a959cb7801aea64c26704d

Do note that this breaks libfive, which has no dependants.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

signature.asc
Description: PGP signature

--- End Message ---