emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#42650: closed ([PATCH 1/2] gnu: python-protobuf: Update to 3.12.4.)


From: GNU bug Tracking System
Subject: bug#42650: closed ([PATCH 1/2] gnu: python-protobuf: Update to 3.12.4.)
Date: Mon, 03 Aug 2020 07:07:01 +0000

Your message dated Mon, 03 Aug 2020 09:05:40 +0200
with message-id <87o8nsus3f.fsf@gnu.org>
and subject line Re: [bug#42650] [PATCH 2/2] gnu: Add python-onnx.
has caused the debbugs.gnu.org bug report #42650,
regarding [PATCH 1/2] gnu: python-protobuf: Update to 3.12.4.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
42650: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42650
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH 1/2] gnu: python-protobuf: Update to 3.12.4. Date: Sat, 1 Aug 2020 11:43:20 -0300
* gnu/packages/protobuf.scm (python-protobuf): Update to 3.12.4.
---
 gnu/packages/protobuf.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/protobuf.scm b/gnu/packages/protobuf.scm
index 7c14ddbdfa..b8bd617eca 100644
--- a/gnu/packages/protobuf.scm
+++ b/gnu/packages/protobuf.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2017, 2018, 2019 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2017, 2018, 2019, 2020 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2020 Vinicius Monego <monego@posteo.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -206,15 +207,17 @@ encoder in C++.  The developer using protozero has to 
manually translate the
 (define-public python-protobuf
   (package
     (name "python-protobuf")
-    (version "3.11.3")
+    (version "3.12.4")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "protobuf" version))
        (sha256
         (base32
-         "07qby3yc2a8a1vsxnc79j687q4r68k1d3npni7bldwmd3m6rfz67"))))
+         "0mj6z58aiw532s1mq48m9xdrm3gdyp2vv9cdinfb5wmnfpm5m7n9"))))
     (build-system python-build-system)
+    (native-inputs
+     `(("python-wheel" ,python-wheel)))
     (propagated-inputs
      `(("python-six" ,python-six)))
     (home-page "https://github.com/google/protobuf";)
-- 
2.20.1




--- End Message ---
--- Begin Message --- Subject: Re: [bug#42650] [PATCH 2/2] gnu: Add python-onnx. Date: Mon, 03 Aug 2020 09:05:40 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
Hello,

A few comments on this one.

> * gnu/packages/machine-learning.scm (python-onnx): New variable.

You need to mention the added file in the commit message and also add it
to gnu/local.mk.

> +       ;; ONNX will build googletest from a git checkout.  Patch CMake
> +       ;; to use googletest from Guix and enable tests by default.

That seems to be a recurrent issue. Did you fix it by yourself or is
there a patch out there? 

Otherwise both patches look fine. I fixed the patch registering thing
and pushed.

Thanks,

Mathieu


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]