emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#40340: closed ([PATCH] etc: indent-code.el: Use the --quick option.)


From: GNU bug Tracking System
Subject: bug#40340: closed ([PATCH] etc: indent-code.el: Use the --quick option.)
Date: Fri, 15 May 2020 03:10:02 +0000

Your message dated Thu, 14 May 2020 23:09:11 -0400
with message-id <address@hidden>
and subject line Re: [bug#40340] [PATCH] etc: indent-code.el: Use the --quick 
option.
has caused the debbugs.gnu.org bug report #40340,
regarding [PATCH] etc: indent-code.el: Use the --quick option.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
40340: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40340
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH] etc: indent-code.el: Use the --quick option. Date: Tue, 31 Mar 2020 00:41:25 -0400
Hello!

I noticed two small annoyances with the indent-code.el script, which are
explained and fixed in the attached patch.

Attachment: 0001-etc-indent-code.el-Use-the-quick-option.patch
Description: Text Data

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- Subject: Re: [bug#40340] [PATCH] etc: indent-code.el: Use the --quick option. Date: Thu, 14 May 2020 23:09:11 -0400 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
Hello Simon,

zimoun <address@hidden> writes:

> Hi Maxim,
>
> On Tue, 31 Mar 2020 at 06:42, Maxim Cournoyer <address@hidden> wrote:
>
>> * configure.ac: Remove the warning about Emacs.  Emacs can now be installed
>> any time by the user if they want to use the script.
>
> The point of this warning was to inform (teach) the user if they does
> not know how to use 'etc/indent-code.el'; basically newcomers which do
> not use Emacs and do not read manual cover to cover.
> Well, maybe it is not useful since the manual already explains [1] and
> this message is meaningful by itself:
>
> ./etc/indent-code.el gnu/packages/maths.scm
> ./etc/indent-code.el: line 1: exec: emacs: not found
>
> [1] https://guix.gnu.org/manual/devel/en/guix.html#Formatting-Code
>
>
> Thank you for the improvement.

The warning was indeed useful before this change, as the script was not
generated in the event Emacs was not found at configuration time.  Now
that the script is always available, it can be removed.

I went ahead and merged this as commit cb21ae7671.

Thank you for taking a look :-).

Maxim


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]