bug#41027: closed ([PATCH core-updates] gnu: python-s3transfer: Fix build with Python 3.8.)

[GNU bug Tracking System]

Your message dated Wed, 13 May 2020 19:10:21 +0100
with message-id <address@hidden>
and subject line Re: [bug#41027] [PATCH core-updates] gnu: python-s3transfer: 
Fix build with Python 3.8.
has caused the debbugs.gnu.org bug report #41027,
regarding [PATCH core-updates] gnu: python-s3transfer: Fix build with Python 
3.8.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
41027: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41027
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH core-updates] gnu: python-s3transfer: Fix build with Python 3.8.
>
>
>
>
> Date: 
>
> Sat,  2 May 2020 15:44:41 +0100
>
>
>
>
> * gnu/packages/python-web.scm (python-s3transfer)[arguments]: Add a 'patch
> phase to fix a test to work under Python 3.8.
> ---
>  gnu/packages/python-web.scm | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index 27749246d8..56887ef9d4 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -2204,6 +2204,15 @@ Betamax.")
>      (arguments
>       `(#:phases
>         (modify-phases %standard-phases
> +         (add-after 'unpack 'patch
> +           (lambda _
> +             ;; There's a small issue with one test with Python 3.8, this
> +             ;; change has been suggested upstream:
> +             ;; https://github.com/boto/s3transfer/pull/164
> +             (substitute* "tests/unit/test_s3transfer.py"
> +               (("super\\(FailedDownloadParts, self\\)\\.submit\\(function\\)")
> +                "futures.Future()"))
> +             #t))
>           (replace 'check
>             (lambda _
>               ;; Some of the 'integration' tests require network access or
> -- 
> 2.26.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#41027] [PATCH core-updates] gnu: python-s3transfer: Fix build with Python 3.8. Date: Wed, 13 May 2020 19:10:21 +0100 User-agent: mu4e 1.2.0; emacs 26.3

Christopher Baines <address@hidden> writes:

> * gnu/packages/python-web.scm (python-s3transfer)[arguments]: Add a 'patch
> phase to fix a test to work under Python 3.8.
> ---
>  gnu/packages/python-web.scm | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index 27749246d8..56887ef9d4 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -2204,6 +2204,15 @@ Betamax.")
>      (arguments
>       `(#:phases
>         (modify-phases %standard-phases
> +         (add-after 'unpack 'patch
> +           (lambda _
> +             ;; There's a small issue with one test with Python 3.8, this
> +             ;; change has been suggested upstream:
> +             ;; https://github.com/boto/s3transfer/pull/164
> +             (substitute* "tests/unit/test_s3transfer.py"
> +               (("super\\(FailedDownloadParts, 
> self\\)\\.submit\\(function\\)")
> +                "futures.Future()"))
> +             #t))
>           (replace 'check
>             (lambda _
>               ;; Some of the 'integration' tests require network access or

I pushed this as c63bd847816061e76389e93dc094df98800f081b back on the
4th of May, but forgot to close the bug.

signature.asc
Description: PGP signature

--- End Message ---