--- Begin Message ---
|
Subject: |
[PATCH] Add PureScript |
|
Date: |
Fri, 13 Dec 2019 18:46:33 +0000 |
Hi Guix,
Here are my patches for PureScript, a haskell inspired language that compiles to _javascript_.
I took all dependencies with the exception of one from stackage lts14.
The exception is language-_javascript_. What do I do about that?
There were a few more dependencies that are not in the stackage lts, but I did not make them publically available and placed them in purescript.scm.
I did a lint and fixed most of the errors I could and built with --rounds=2 --check.
Thanks!
John
0001-gnu-Add-ghc-utf8-light.patch
Description: Text Data
0002-gnu-Add-ghc-transformers.patch
Description: Text Data
0005-gnu-Add-ghc-wai-websockets.patch
Description: Text Data
0004-gnu-Add-ghc-websockets.patch
Description: Text Data
0003-gnu-Add-ghc-tasty-hspec.patch
Description: Text Data
0006-gnu-Add-ghc-sourcemap.patch
Description: Text Data
0007-gnu-Add-ghc-mtl-compat.patch
Description: Text Data
0008-gnu-Add-ghc-protolude.patch
Description: Text Data
0009-gnu-Add-ghc-pattern-arrows.patch
Description: Text Data
0010-gnu-Add-ghc-language-javascript.patch
Description: Text Data
0011-gnu-Add-ghc-bower-json.patch
Description: Text Data
0013-gnu-Add-ghc-assoc.patch
Description: Text Data
0015-gnu-Add-ghc-semialign.patch
Description: Text Data
0014-gnu-Add-ghc-these.patch
Description: Text Data
0012-gnu-Add-ghc-aeson-better-errors.patch
Description: Text Data
0016-gnu-Add-ghc-happy-1.19.9.patch
Description: Text Data
0017-gnu-Add-ghc-clock-0.7.2.patch
Description: Text Data
0018-gnu-Add-ghc-glob-0.9.3.patch
Description: Text Data
0019-gnu-Add-ghc-ansi-terminal-0.8.2.patch
Description: Text Data
0020-gnu-Add-ghc-lifted-async-0.10.0.4.patch
Description: Text Data
0022-gnu-Add-purescript.patch
Description: Text Data
0021-gnu-Add-ghc-network-3.0.1.1.patch
Description: Text Data
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: [bug#38596] [PATCH] gnu: Add PureScript. |
|
Date: |
Fri, 08 May 2020 10:13:25 +0100 |
|
User-agent: |
mu4e 1.2.0; emacs 26.3 |
John Soo <address@hidden> writes:
> Christopher Baines <address@hidden> writes:
>
>> Some really minor description things I missed earlier:
>>
>> ghc-aeson-better-errors, ghc-transformers and ghc-websockets have URLs
>> in the description, @url could probably be used.
>>
>> I'd also remove the following from the ghc-bower-json description, it
>> reads more like uninformative advertising to me and isn't really
>> relevant to this specific package:
>>
>> Bower is a package manager for the web (see http://bower.io).
>
> Done!
>
>> Maybe it would be good to note why the package in Guix didn't work, like
>> I tried to use ghc-happy@1.19.12, and the build phase failed with some
>> type errors. That'll at least point out clearly that there's an
>> incompatability. I don't think much detail is needed, the following
>> would be fine.
>>
>> `(("ghc-happy" ,ghc-happy-1.19.9) ; build fails with 1.19.12
>
> Done!
>
>>> Ah thanks for the suggestion here. I found one that could be taken from
>>> the existing package in (gnu packages haskell-xyz). The rest seemed to
>>> be either pinned exactly or too strict to take from guix packages.
>>
>> Thanks, although my intent was more about adding something like this.
>>
>> #:phases
>> (modify-phases %standard-phases
>> (add-after 'unpack 'patch
>> (lambda _
>> (substitute* "purescript.cabal"
>> (("clock .*$")
>> "clock,\n"))
>> #t)))))
>
> With the addition of a patch I was able to relax most of the package
> versions I introduced to ones we have. The final remaining required
> dependency seems to be happy which I kept at 1.19.9.
Awesome. I added the patch to the list in gnu/local.mk, which I think is
necessary when building the guix package for guix at least. I also added
a small comment to the top of the patch.
>> Now I'm not sure quite how risky this is, the purescript tests aren't
>> being run, but given this is Haskell and it compiles, hopefully that
>> provides some guarantees.
>>
>> What do you think?
>
> My only caveat too is now I have not really tested this version. I had
> done some work with a prior version. I wish I could run the tests but
> they seem to rely heavily on npm and bower.
Personally, I think that's fine for the moment. It builds at least and I
can run purs to at least get the help.
I've gone ahead and pushed these patches as
de488b3a5fff4535471f6706da03e1b74e6a37fd, thanks for all your work!
Chris
signature.asc
Description: PGP signature
--- End Message ---