--- Begin Message ---
|
Subject: |
[PATCH] Add makepasswd package |
|
Date: |
Sat, 02 May 2020 20:37:28 +0000 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Dear Guix maintainers,
Here is an attempt at packaging makepasswd, a run-time dependency of
x2go.
I've placed it in its own file which may be ill-advised for now; please
let me know where I could more sensibly move it.
Hopefully patches will follow that put more flesh in this x2go.scm file;
however I find this program useful in its own right.
Kind regards,
Jean-Baptiste
0001-x2go-Add-makepasswd.patch
Description: add makepasswd
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: [bug#41032] [PATCH] Add makepasswd package |
|
Date: |
Wed, 06 May 2020 22:29:58 +0200 |
|
User-agent: |
Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) |
Jean-Baptiste Note <address@hidden> writes:
> Hi Marius,
>
> Thanks for your review and the heads up on the correct file.
> Please find an updated patch.
>
> I've used guix-devel-mode and ran indent-according-to-mode on the buffer
> before producing the patch; let me know if this is not sufficient to
> correctly indent the code :)
Thanks! My Emacs agrees, so LGTM.
[...]
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (delete 'configure))
> + #:make-flags (list "CC=gcc" (string-append "PREFIX=" (assoc-ref
> %outputs "out")))
I moved the second flag to its own line as 89 characters is a bit much.
> + #:tests? #f))
And added a comment about why tests are disabled.
> + (synopsis "Generate (pseudo-)random passwords and hashes")
> + (description
> + "Makepasswd is a program that generates pseudo-random passwords of a
> +desired length. It can also generate their corresponding hashes for a given
> +encryption algorithm if so desired.")
> + (home-page "https://github.com/khorben/makepasswd";)
> + (license license:gpl3))))
Indeed GPL3 only :-/
Applied!
signature.asc
Description: PGP signature
--- End Message ---