bug#38951: closed (gnu: Add libgovirt.)

[GNU bug Tracking System]

Your message dated Mon, 13 Jan 2020 17:17:51 +0100
with message-id <address@hidden>
and subject line Re: [bug#38951] gnu: Add libgovirt.
has caused the debbugs.gnu.org bug report #38951,
regarding gnu: Add libgovirt.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
38951: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38951
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: gnu: Add libgovirt. Date: Sun, 05 Jan 2020 18:55:43 +0000

Hello Guix!

Please find the attached patch to add libgovirt.

Thank you!

Regards,
RG.

libgovirt.patch
Description: Binary data

--- End Message ---

--- Begin Message --- Subject: Re: [bug#38951] gnu: Add libgovirt. Date: Mon, 13 Jan 2020 17:17:51 +0100

Hi Raghav,

I've found the reason for the test failure by using this patch:

--- libgovirt-0.3.6/tests/mock-httpd.c.orig     2020-01-13 16:54:08.578009738 
+0100
+++ libgovirt-0.3.6/tests/mock-httpd.c  2020-01-13 16:54:58.442238829 +0100
@@ -114,6 +114,9 @@
                cert = g_tls_certificate_new_from_files (abs_srcdir 
"/https-cert/server-cert.pem",
                                                         abs_srcdir 
"/https-cert/server-key.pem",
                                                         &error);
+               if (error != NULL) {
+                       fprintf(stderr, "ERROR: %s\n", error->message);
+               }
                g_assert (error == NULL);
                server = soup_server_new (SOUP_SERVER_SERVER_HEADER, 
"simple-soup-httpd ",
                                          SOUP_SERVER_TLS_CERTIFICATE, cert,

Then I fixed the test failure by adding glib-networking (which is a GIO plugin).

I suspect that the tests won't work reliably because of the networking
involved (even when local)--but let's cross that bridge when we come to it.

Committed to guix master as commit 3f1ed953e8a596dc3a4924758a931b8a774bde5f.

pgpB_FiAjfVnr.pgp
Description: OpenPGP digital signature

--- End Message ---