bug#38926: closed (pcmanfm-qt unable to open files by double click)

[GNU bug Tracking System]

Your message dated Sat, 11 Jan 2020 21:28:42 +0100
with message-id <address@hidden>
and subject line Re: [bug#39004] [PATCH] gnu: pcmanfm-qt: fix open file issue
has caused the debbugs.gnu.org bug report #38926,
regarding pcmanfm-qt unable to open files by double click
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
38926: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38926
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> pcmanfm-qt unable to open files by double click
>
>
>
>
> Date: 
>
> Sat, 04 Jan 2020 23:54:59 +0330
>
>
>
>
> User-agent: 
>
> Cyrus-JMAP/3.1.7-694-gd5bab98-fmstable-20191218v1
>
>
>
>
> Hi, 
>
> there is an issue with `pcmanfm-qt`. when we try to open a known file using
> double click, we receive following error:
>
> --8<---------------cut here---------------start------------->8---
> Failed to execute child process “gio-launch-desktop” (No such file or directory)
> --8<---------------cut here---------------end--------------->8---
>
>
> since `gio-launch-desktop` is located in `bin` output of `glib` package,
> adding that as a propagated input for `pcmanfm-qt` fixes this issue.
>
> --8<---------------cut here---------------start------------->8---
> diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
> index 5a3708e30a..2337daa7c3 100644
> --- a/gnu/packages/lxqt.scm
> +++ b/gnu/packages/lxqt.scm
> @@ -991,6 +991,8 @@ components to build desktop file managers which belongs to 
> LXDE.")
>       `(("pkg-config" ,pkg-config)
>         ("qttools" ,qttools)
>         ("lxqt-build-tools" ,lxqt-build-tools)))
> +    (propagated-inputs 
> +      `(("glib" ,glib "bin")))
>      (arguments
>       '(#:tests? #f                      ; no tests
>         #:phases
> --8<---------------cut here---------------end--------------->8---
>
> is this change is acceptable? if so I can submit a regarding patch to
> `guix-patches` mailing list.
>
>
> --
> Regards
> Reza Alizadeh Majd
> PantherX Team
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#39004] [PATCH] gnu: pcmanfm-qt: fix open file issue Date: Sat, 11 Jan 2020 21:28:42 +0100 User-agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu)

Hi Reza,

"Reza Alizadeh Majd" <address@hidden> writes:

> it could be great to have this patch merged, if there is no other issues 
>  existed with this change. 

I've applied the patch, with minor cosmetic adjustments (fixing typo,
naming the input "glib:bin" as we usually do), as well as a commit
message following our guidelines.

Thanks for the bug report and fix!

signature.asc
Description: PGP signature

--- End Message ---