bug#38849: closed (Fix IBus-Rime)

[GNU bug Tracking System]

Your message dated Mon, 06 Jan 2020 15:26:54 +0100
with message-id <address@hidden>
and subject line Re: [bug#38849] Fix IBus-Rime
has caused the debbugs.gnu.org bug report #38849,
regarding Fix IBus-Rime
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
38849: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38849
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Fix IBus-Rime
>
>
>
>
> Date: 
>
> Wed, 01 Jan 2020 13:28:28 +0300
>
>
>
>
> IBus uses the component file rime.xml to start the Rime engine. It must be 
> patched with appropriate paths.
>
> ---
>  gnu/packages/ibus.scm | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/gnu/packages/ibus.scm b/gnu/packages/ibus.scm
> index 42a8d5db32..7daefde021 100644
> --- a/gnu/packages/ibus.scm
> +++ b/gnu/packages/ibus.scm
> @@ -668,6 +668,10 @@ Method Engine.")
>                                 (assoc-ref inputs "rime-data")
>                                 "/share/rime-data\"\n")))
>               #t))
> +         (add-after 'unpack 'fix-paths
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (substitute* "rime.xml"
> +               (("/usr") (assoc-ref outputs "out"))) #t))
>           (delete 'configure))))
>      (inputs
>       `(("gdk-pixbuf" ,gdk-pixbuf)
> -- 
> 2.23.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#38849] Fix IBus-Rime
>
>
>
>
> Date: 
>
> Mon, 06 Jan 2020 15:26:54 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
>
>
>
>
> Hello,
>
> address@hidden skribis:
>
> > IBus uses the component file rime.xml to start the Rime engine. It must be 
> > patched with appropriate paths.
> >
> > ---
> >  gnu/packages/ibus.scm | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/gnu/packages/ibus.scm b/gnu/packages/ibus.scm
> > index 42a8d5db32..7daefde021 100644
> > --- a/gnu/packages/ibus.scm
> > +++ b/gnu/packages/ibus.scm
> > @@ -668,6 +668,10 @@ Method Engine.")
> >                                 (assoc-ref inputs "rime-data")
> >                                 "/share/rime-data\"\n")))
> >               #t))
> > +         (add-after 'unpack 'fix-paths
> > +           (lambda* (#:key outputs #:allow-other-keys)
> > +             (substitute* "rime.xml"
> > +               (("/usr") (assoc-ref outputs "out"))) #t))
>
> I made the following changes:
>
>   1. Move the explanation as a comment in the code.
>
>   2. Write “file name” instead of “path”, for consistency.
>
>   3. Write a commit log that follows the project’s conventions.
>
> Committed now, thank you!
>
> Ludo’.
>
>
> --- End Message ---