bug#33218: closed (Updated dfa.c: unused function charclass_context)

[GNU bug Tracking System]

Your message dated Wed, 1 Jan 2020 17:27:18 -0800
with message-id <address@hidden>
and subject line Re: Updated dfa.c: unused function charclass_context
has caused the debbugs.gnu.org bug report #33218,
regarding Updated dfa.c: unused function charclass_context
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
33218: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33218
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Updated dfa.c: unused function charclass_context
>
>
>
>
> Date: 
>
> Wed, 31 Oct 2018 21:53:29 +0200
>
>
>
>
> User-agent: 
>
> Heirloom mailx 12.5 6/20/10
>
>
>
>
> Hi.
>
> I have merged the latest dfa.c into gawk.  When I compile it, I get the
> following warning:
>
> dfa.c:2352:1: warning: 'charclass_context' defined but not used 
> [-Wunused-function]
>
> And indeed, the function isn't used. So I have removed it.
>
> Thanks,
>
> Arnold
> ----------------------
> diff --git a/support/dfa.c b/support/dfa.c
> index 71c350e..0f0a661 100644
> --- a/support/dfa.c
> +++ b/support/dfa.c
> @@ -2345,27 +2345,6 @@ epsclosure (struct dfa const *d)
>    free (tmp.elems);
>  }
>  
> -/* Returns the set of contexts for which there is at least one
> -   character included in C.  */
> -
> -static int
> -charclass_context (struct dfa const *dfa, charclass const *c)
> -{
> -  int context = 0;
> -
> -  for (unsigned int j = 0; j < CHARCLASS_WORDS; ++j)
> -    {
> -      if (c->w[j] & dfa->syntax.newline.w[j])
> -        context |= CTX_NEWLINE;
> -      if (c->w[j] & dfa->syntax.letters.w[j])
> -        context |= CTX_LETTER;
> -      if (c->w[j] & ~(dfa->syntax.letters.w[j] | dfa->syntax.newline.w[j]))
> -        context |= CTX_NONE;
> -    }
> -
> -  return context;
> -}
> -
>  /* Returns the contexts on which the position set S depends.  Each context
>     in the set of returned contexts (let's call it SC) may have a different
>     follow set than other contexts in SC, and also different from the
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: Updated dfa.c: unused function charclass_context
>
>
>
>
> Date: 
>
> Wed, 1 Jan 2020 17:27:18 -0800
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2
>
>
>
>
> Bug#33218 dated 2018-10-31 seems to have been fixed by Jim Meyering in Gnulib 
> commit 95cd86dd7aa4425037b9c710f88fd59e38601ff1 (2018-12-15 18:09:35 UTC) and 
> then fixed in a different way since then, so I'm closing this old bug report.
>
>
> --- End Message ---