bug#38841: closed (Enhancement request: Make show_help a bool)

[GNU bug Tracking System]

Your message dated Tue, 31 Dec 2019 23:17:52 -0800
with message-id <address@hidden>
and subject line Re: bug#38841: Enhancement request: Make show_help a bool
has caused the debbugs.gnu.org bug report #38841,
regarding Enhancement request: Make show_help a bool
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
38841: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38841
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Enhancement request: Make show_help a bool
>
>
>
>
> Date: 
>
> Wed, 1 Jan 2020 02:52:14 +0100
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0
>
>
>
>
> Hi, why is "static int show_help on line65 in src/grep.c a int?
> It's value is only set once in "src/grep.c:2704" to a 1.
> Wouldn't it be better to make it a bool?
>
> As this my first mail to a GNU project ever I don't know how to properly 
> contribute code, are there methods like Pull Requests or do I need to 
> submit a patch the traditional way through a diff on a mailing list?
>
> Greetings and Happy New Year,
> Emil Engler
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#38841: Enhancement request: Make show_help a bool
>
>
>
>
> Date: 
>
> Tue, 31 Dec 2019 23:17:52 -0800
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2
>
>
>
>
> On 12/31/19 5:52 PM, Emil Engler wrote:
> > Hi, why is "static int show_help on line65 in src/grep.c a int?
>
> Its address is taken in a long_options initializer, where the context requires
> an int *. You could have found that out by changing it to bool and trying to
> compile.
>
>
> --- End Message ---