bug#38040: closed (Compiler warnings on win32 build)

[GNU bug Tracking System]

Your message dated Thu, 14 Nov 2019 11:18:32 +0200
with message-id <address@hidden>
and subject line Re: bug#38040: Compiler warnings on win32 build
has caused the debbugs.gnu.org bug report #38040,
regarding Compiler warnings on win32 build
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
38040: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38040
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Compiler warnings on win32 build
>
>
>
>
> Date: 
>
> Sun, 03 Nov 2019 01:36:41 +0100
>
>
>
>
> Severity: wishlist
> Tags: patch
>
> Building with mingw64, there are a couple of warnings about wrong data
> types that can be avoided:
>
>
> diff --git a/nt/addpm.c b/nt/addpm.c
> index a8bcd4a5c7..ff169f7d87 100644
> --- a/nt/addpm.c
> +++ b/nt/addpm.c
> @@ -56,13 +56,13 @@ #define COBJMACROS 1
>  #include "../src/epaths.h"
>  #endif
>  
> -HDDEDATA CALLBACK DdeCallback (UINT, UINT, HCONV, HSZ, HSZ, HDDEDATA, DWORD,
> -                              DWORD);
> +HDDEDATA CALLBACK DdeCallback (UINT, UINT, HCONV, HSZ, HSZ, HDDEDATA, 
> ULONG_PTR,
> +                              ULONG_PTR);
>  
>  HDDEDATA CALLBACK
>  DdeCallback (UINT uType, UINT uFmt, HCONV hconv,
>              HSZ hsz1, HSZ hsz2, HDDEDATA hdata,
> -            DWORD dwData1, DWORD dwData2)
> +            ULONG_PTR dwData1, ULONG_PTR dwData2)
>  {
>    return ((HDDEDATA) NULL);
>  }
> diff --git a/nt/ddeclient.c b/nt/ddeclient.c
> index e441700397..a63be13f75 100644
> --- a/nt/ddeclient.c
> +++ b/nt/ddeclient.c
> @@ -21,13 +21,13 @@
>  #include <stdlib.h>
>  #include <stdio.h>
>  
> -HDDEDATA CALLBACK DdeCallback (UINT, UINT, HCONV, HSZ, HSZ, HDDEDATA, DWORD,
> -                              DWORD);
> +HDDEDATA CALLBACK DdeCallback (UINT, UINT, HCONV, HSZ, HSZ, HDDEDATA, 
> ULONG_PTR,
> +                              ULONG_PTR);
>  
>  HDDEDATA CALLBACK
>  DdeCallback (UINT uType, UINT uFmt, HCONV hconv,
>              HSZ hsz1, HSZ hsz2, HDDEDATA hdata,
> -            DWORD dwData1, DWORD dwData2)
> +            ULONG_PTR dwData1, ULONG_PTR dwData2)
>  {
>    return ((HDDEDATA) NULL);
>  }
>
>
>
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#38040: Compiler warnings on win32 build
>
>
>
>
> Date: 
>
> Thu, 14 Nov 2019 11:18:32 +0200
>
>
>
>
> > From: Cecilio Pardo <address@hidden>
> > Cc: Cecilio Pardo <address@hidden>,  address@hidden
> > Date: Sun, 10 Nov 2019 01:03:51 +0100
> > 
> > 
> > >> Building with mingw64, there are a couple of warnings about wrong data
> > >> types that can be avoided:
> > >
> > > Thanks, I installed a slightly different change, because these types
> > > are declared DWORD in mingw.org's MinGW headers.  Please see that the
> > > warnings are gone in your build.
> > 
> > They are gone. Thanks for fixing this.
>
> Thanks, closing.
>
>
> --- End Message ---