bug#38120: closed ([PATCH] gnu: Add geonkick.)

[GNU bug Tracking System]

Your message dated Wed, 13 Nov 2019 23:30:07 +0100
with message-id <address@hidden>
and subject line Re: [bug#38120] [PATCH] gnu: Add geonkick.
has caused the debbugs.gnu.org bug report #38120,
regarding [PATCH] gnu: Add geonkick.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
38120: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38120
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Add geonkick.
>
>
>
>
> Date: 
>
> Fri, 08 Nov 2019 11:13:12 +0100
>
>
>
>
> User-agent: 
>
> Posteo Webmail
>
>
>
>
> From 09c3a68bfd70d80984a5956fad0596bb7c3e07ac Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <address@hidden>
> Date: Fri, 8 Nov 2019 10:11:50 +0000
> Subject: [PATCH] gnu: Add geonkick.
>
> * gnu/packages/music.scm: (geonkick): New variable.
> ---
>  gnu/packages/music.scm | 40 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index a30765e87f..eae05499a1 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -24,6 +24,7 @@
>  ;;; Copyright © 2019 Jakob L. Kreuze <address@hidden>
>  ;;; Copyright © 2019 raingloom <address@hidden>
>  ;;; Copyright © 2019 David Wilson <address@hidden>
> +;;; Copyright © 2019 Alexandros Theodotou <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -4699,3 +4700,42 @@ You can also get metadata about the playing track 
> such as the artist and title
>  for integration into status line generators or other command-line 
> tools.")
>      (home-page "https://github.com/altdesktop/playerctl";)
>      (license license:lgpl3+)))
> +
> +(define-public geonkick
> +  (package
> +    (name "geonkick")
> +    (version "1.9.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append 
> "https://gitlab.com/iurie/geonkick/-/archive/v";
> +                            version "/geonkick-v" version ".tar.gz"))
> +        (sha256
> +          (base32
> +            "0wp8w5q69c1nrcc4qkcg0slakkpzp9ngw25iih8zhcl4hrjv42fd"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f ; no tests included
> +       #:configure-flags
> +       (list (string-append "-DGKICK_REDKITE_SDK_PATH="
> +                            (assoc-ref %build-inputs "redkite"))
> +             (string-append "-DCMAKE_INSTALL_PREFIX="
> +                            (assoc-ref %outputs "out")))))
> +    (inputs
> +     `(("cairo" ,cairo)
> +       ("hicolor-icon-theme" ,hicolor-icon-theme)
> +       ("jack", jack-1) ; for the standalone
> +       ("libsndfile", libsndfile)
> +       ("libx11", libx11)))
> +    (native-inputs
> +     `(("lv2", lv2)
> +       ("pkg-config", pkg-config)
> +       ("sord", sord)
> +       ("rapidjson", rapidjson)
> +       ("redkite", redkite)))
> +    (synopsis "Percussion synthesizer")
> +    (description "Geonkick is a synthesizer that can synthesize 
> elements of
> +percussion such as kicks, snares, hit-hats, shakers, claps and sticks. 
> It can
> +also play and mix samples.")
> +    (home-page "https://gitlab.com/iurie/geonkick";)
> +    (license license:gpl3+)))
> --
> 2.24.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#38120] [PATCH] gnu: Add geonkick. Date: Wed, 13 Nov 2019 23:30:07 +0100 User-agent: Notmuch/0.29.1 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu)

Alexandros Theodotou <address@hidden> writes:

> From 98c080f2f27d9f7a99dd635948dc062bde75ed1c Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <address@hidden>
> Date: Fri, 8 Nov 2019 10:11:50 +0000
> Subject: [PATCH] gnu: Add geonkick.
>
> * gnu/packages/music.scm: (geonkick): New variable.

[...]

> +(define-public geonkick
> +  (package
> +    (name "geonkick")
> +    (version "1.9.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "https://gitlab.com/iurie/geonkick/-/archive/v";
> +                            version "/geonkick-v" version ".tar.gz"))
> +        (sha256
> +          (base32
> +            "0wp8w5q69c1nrcc4qkcg0slakkpzp9ngw25iih8zhcl4hrjv42fd"))))

As with redkite, I followed the redirect and changed to a git checkout.

> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f ; no tests included
> +       #:configure-flags
> +       (list (string-append "-DGKICK_REDKITE_SDK_PATH="
> +                            (assoc-ref %build-inputs "redkite"))
> +             (string-append "-DCMAKE_INSTALL_PREFIX="
> +                            (assoc-ref %outputs "out")))))
> +    (inputs
> +     `(("cairo" ,cairo)
> +       ("hicolor-icon-theme" ,hicolor-icon-theme)
> +       ("jack" ,jack-1) ; for the standalone JACK application
> +       ("libsndfile" ,libsndfile)
> +       ("libx11" ,libx11)))
> +    (native-inputs
> +     `(("lv2" ,lv2)
> +       ("pkg-config" ,pkg-config)
> +       ("sord" ,sord)
> +       ("rapidjson" ,rapidjson)
> +       ("redkite" ,redkite)))

I moved rapidjson and redkite to inputs, because the package embeds
their static libraries, so the architecture has to match when
cross-compiling.

Applied!

signature.asc
Description: PGP signature

--- End Message ---