emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#38119: closed ([PATCH] gnu: Add redkite.)


From: GNU bug Tracking System
Subject: bug#38119: closed ([PATCH] gnu: Add redkite.)
Date: Wed, 13 Nov 2019 22:29:02 +0000

Your message dated Wed, 13 Nov 2019 23:27:54 +0100
with message-id <address@hidden>
and subject line Re: [bug#38119] [PATCH] gnu: Add redkite.
has caused the debbugs.gnu.org bug report #38119,
regarding [PATCH] gnu: Add redkite.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
38119: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38119
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH] gnu: Add redkite. Date: Fri, 08 Nov 2019 10:58:12 +0100 User-agent: Posteo Webmail
Adding this to audio because it's a GUI toolkit for audio plugins.

From 2991c39c555873b8bed3db3139ce6d35bb156a8e Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <address@hidden>
Date: Fri, 8 Nov 2019 09:47:25 +0000
Subject: [PATCH] gnu: Add redkite.

* gnu/packages/audio.scm: (redkite): New variable.
---
 gnu/packages/audio.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 28dbf06f3b..e13833bf23 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -23,6 +23,7 @@
 ;;; Copyright © 2019 Rutger Helling <address@hidden>
 ;;; Copyright © 2019 Arun Isaac <address@hidden>
 ;;; Copyright © 2019 Mathieu Othacehe <address@hidden>
+;;; Copyright © 2019 Alexandros Theodotou <address@hidden>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3773,3 +3774,30 @@ other Gnaural instances, allowing synchronous sessions between many users.") a sound card, encodes it into Ogg Vorbis and/or mp3, and sends the audio
 stream to one or more IceCast and/or ShoutCast servers.")
     (license license:gpl3+)))
+
+(define-public redkite
+  (package
+    (name "redkite")
+    (version "0.6.2")
+    (source
+      (origin
+        (method url-fetch)
+        (uri
+          (string-append "https://gitlab.com/iurie/redkite/-/archive/v";
+                         version "/redkite-v" version ".tar.gz"))
+        (sha256
+          (base32
+            "0qif1x3s96zi81zkg11zkszf2i5mvfyrg9b3z2lr0jpzihgblk7y"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f)) ; no tests included
+    (inputs
+     `(("cairo" ,cairo)
+       ("glibc" ,glibc)))
+    (native-inputs
+     `(("pkg-config", pkg-config)))
+    (synopsis "Small GUI toolkit")
+    (description "Redkite is a small GUI toolkit developed in C++17 and
+inspired from other well known GUI toolkits.")
+    (home-page "https://gitlab.com/iurie/redkite";)
+    (license license:gpl3+)))
--
2.24.0




--- End Message ---
--- Begin Message --- Subject: Re: [bug#38119] [PATCH] gnu: Add redkite. Date: Wed, 13 Nov 2019 23:27:54 +0100 User-agent: Notmuch/0.29.1 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu)
Alexandros Theodotou <address@hidden> writes:

> Marius,
>
> Thanks for the reviews! Updated.
>
> The new description feels a bit too formal - the upstream descriptions
> were too short so I had to come up with something. Feel free to edit
> it.

Looks good to me!  We can always adjust it later.

On a related note, it feels weird to have a GUI toolkit in audio.scm,
but I could not think of a better place for it.  Suggestions welcome.

> From f50684e58e8b4c6f8bc105dd9f0650fcb366b875 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <address@hidden>
> Date: Fri, 8 Nov 2019 09:47:25 +0000
> Subject: [PATCH] gnu: Add redkite.
>
> * gnu/packages/audio.scm: (redkite): New variable.

Applied, thanks!

[...]

> +    (home-page "https://gitlab.com/iurie/redkite";)

The URL redirects to 'gitlab.com/geontime/redkite', so I updated it.

I also made a follow-up patch that downloads a git checkout instead of
an autogenerated tarball, because the tarball hash might change in the
future when GitLab generates a new one.

Attachment: signature.asc
Description: PGP signature


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]