bug#38107: closed ([PATCH 0/1] Warn about etc/indent-code.el when Emacs is absent.)

[GNU bug Tracking System]

Your message dated Fri, 08 Nov 2019 23:56:26 +0100
with message-id <address@hidden>
and subject line Re: [bug#38107] [PATCH 1/1] configure.ac: Warn about 
etc/indent-code.el when Emacs is absent.
has caused the debbugs.gnu.org bug report #38107,
regarding [PATCH 0/1] Warn about etc/indent-code.el when Emacs is absent.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
38107: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38107
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/1] Warn about etc/indent-code.el when Emacs is absent.
>
>
>
>
> Date: 
>
> Thu,  7 Nov 2019 19:25:18 +0100
>
>
>
>
> Dear,
>
> Currently, if Emacs is absent of PATH then ./configure defaults to
> /usr/bin/emacs, therefore the script etc/indent-code.el fails when the user
> runs it.
>
> With the patch, the file etc/indent-code.el will not be outputed if Emacs is
> absent and ./configure warns the user.
>
> >From my point of view, it avoids trivial mistake of non-Emacs-er newcomers and
> ease their experience when contributing.
>
>
> All the best,
> simon
>
>
> zimoun (1):
>   configure.ac: Warn about etc/indent-code.el when Emacs is absent.
>
>  configure.ac | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> -- 
> 2.23.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#38107] [PATCH 1/1] configure.ac: Warn about etc/indent-code.el when Emacs is absent.
>
>
>
>
> Date: 
>
> Fri, 08 Nov 2019 23:56:26 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
>
>
>
>
> zimoun <address@hidden> skribis:
>
> > ---
> >  configure.ac | 11 ++++++++---
> >  1 file changed, 8 insertions(+), 3 deletions(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 689b28d984..599addfe59 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -280,9 +280,14 @@ dnl Documentation translation.
> >  AM_MISSING_PROG([PO4A_TRANSLATE], [po4a-translate])
> >  AM_MISSING_PROG([PO4A_UPDATEPO], [po4a-updatepo])
> >  
> > -dnl Emacs (optional), for 'etc/indent-package.el'.
> > -AC_PATH_PROG([EMACS], [emacs], [/usr/bin/emacs])
> > -AC_SUBST([EMACS])
> > +dnl Emacs (optional), for 'etc/indent-code.el'.
> > +AC_PATH_PROG([EMACS], [emacs])
> > +if test "x$EMACS" = x; then
> > +    AC_MSG_WARN([Install GNU Emacs to use etc/indent-code.el])
> > +else
> > +    AC_SUBST([EMACS])
> > +    AC_CONFIG_FILES([etc/indent-code.el], [chmod +x etc/indent-code.el])
> > +fi
>
> I removed the redundant ‘AC_CONFIG_FILES’ from the bottom, adjusted the
> commit log, and applied.
>
> Thanks!
>
> Ludo’.
>
>
> --- End Message ---