bug#38073: closed ([PATCH] gnu: grantlee: Fix build for Qt 5.12.)

[GNU bug Tracking System]

Your message dated Wed, 6 Nov 2019 10:31:42 +0100
with message-id <address@hidden>
and subject line Re: [bug#38073] [PATCH] gnu: grantlee: Fix build for Qt 5.12.
has caused the debbugs.gnu.org bug report #38073,
regarding [PATCH] gnu: grantlee: Fix build for Qt 5.12.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
38073: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38073
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: grantlee: Fix build for Qt 5.12.
>
>
>
>
> Date: 
>
> Tue,  5 Nov 2019 22:00:43 +0100
>
>
>
>
> Build using gnu++11 standard.
>
> * gnu/packages/qt.scm(grantlee)[argument]<configure-flags>: New
>   element.
> ---
>  gnu/packages/qt.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
> index 8928c1ddd4..0ef879678f 100644
> --- a/gnu/packages/qt.scm
> +++ b/gnu/packages/qt.scm
> @@ -100,7 +100,8 @@
>         ("qtscript" ,qtscript)))
>      (build-system cmake-build-system)
>      (arguments
> -     `(#:phases
> +     `(#:configure-flags '("-DCMAKE_CXX_STANDARD=11")
> +       #:phases
>         (modify-phases %standard-phases
>           (add-after 'unpack 'delete-broken-tests
>             (lambda _
> -- 
> 2.21.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#38073] [PATCH] gnu: grantlee: Fix build for Qt 5.12.
>
>
>
>
> Date: 
>
> Wed, 6 Nov 2019 10:31:42 +0100
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1
>
>
>
>
> Am 06.11.19 um 08:09 schrieb Efraim Flashner:
> > Looks good to me. Assuming it builds go ahead and push it to master or
> > staging, whichever is better for it.
> >
> >
> Pushed to staging, as Qt 5.12 is not yet in master.
>
> ea57bb893eeb7008064d2f511dede616d4bdcbd1
>
> Thanks for the review.
>
> -- 
> Regards
> Hartmut Goebel
>
> | Hartmut Goebel          | address@hidden               |
> | www.crazy-compilers.com | compilers which you thought are impossible |
>
>
>
> --- End Message ---