--- Begin Message ---
|
Subject: |
[PATCH 0/2] Remove monolithic qt5 (and other unused package) |
|
Date: |
Thu, 24 Oct 2019 21:20:56 +0200 |
The monolithic `qt` package was only used as a base to inhert `qt-4` from.
For testing this change does not change qt-4 in any way:
- run ./pre-inst-env guix build qt@4.8.7
- apply patch
- again run ./pre-inst-env guix build qt@4.8.7
-> qt@4.8.7 will *not* be build again. To avoid any rebuilds, I even refrined
from sorting the inputs. :-)
The other patch removes a package which has been merged into qtdeclarative as
of Qt 5.8.0 and is not used anywhere.
Hartmut Goebel (2):
gnu: Remove qtdeclarative-render2d.
gnu: Remove monolithic qt5.
gnu/packages/qt.scm | 328 +++++++-------------------------------------
1 file changed, 49 insertions(+), 279 deletions(-)
--
2.21.0
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: [bug#37908] [PATCH 0/2] Remove monolithic qt5 (and other unused package) |
|
Date: |
Fri, 1 Nov 2019 17:09:43 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
Am 01.11.19 um 15:39 schrieb Efraim Flashner:
>> Please ensure that “guix build qt@4 -nd” returns the same derivation
>> before and after the change.
Done already before submitting the patch :-) But I repeated it now and
this revealed some error. So many thanks for nagging :-)
>>
>> Perhaps add a comment above saying that ‘qt’ used to refer to the
>> monolithic Qt 5.x package?
Done.
> I didn't apply it locally, I can do it in about 36 hours, but it looks
> good. IIRC we have qt4 inheriting from qt5, and qtbase was its own
> definition so nothing should change on that side.
Correct. I added some more explanation to the commit message to make
this more clear.
Pushed as 02511196d99ebc5e385e9dc7f733ffbe848e25ca
--
Regards
Hartmut Goebel
| Hartmut Goebel | address@hidden |
| www.crazy-compilers.com | compilers which you thought are impossible |
signature.asc
Description: OpenPGP digital signature
--- End Message ---