[debbugs-tracker] bug#21893: closed (25.0.50; Using scroll-*-command in follow-mode)

[GNU bug Tracking System]

Your message dated Sun, 29 Sep 2019 23:40:04 +0200
with message-id <CADwFkm=address@hidden>
and subject line Re: bug#21893: 25.0.50; Using scroll-*-command in follow-mode
has caused the debbugs.gnu.org bug report #21893,
regarding 25.0.50; Using scroll-*-command in follow-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
21893: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21893
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 25.0.50; Using scroll-*-command in follow-mode
>
>
>
>
> Date: 
>
> Thu, 12 Nov 2015 23:07:50 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu)
>
>
>
>
> follow.el could use better commands scroll-up-command/scroll-down-command
> like in this patch to work smoothly when scroll-error-top-bottom is t,
> but a special condition in follow-scroll-up/follow-scroll-down
> that checks for scroll-preserve-screen-position prevents from scrolling
> and returns point to the old position, and there is no comment
> explaining this special-casing.
>
> diff --git a/lisp/follow.el b/lisp/follow.el
> index 938c59e..fa24a28 100644
> --- a/lisp/follow.el
> +++ b/lisp/follow.el
> @@ -518,14 +518,14 @@ (defun follow-scroll-up (&optional arg)
>  Works like `scroll-up' when not in Follow mode."
>    (interactive "P")
>    (cond ((not follow-mode)
> -        (scroll-up arg))
> +        (scroll-up-command arg))
>         ((eq arg '-)
>          (follow-scroll-down))
>         (t
>          (let ((opoint (point))  (owin (selected-window)))
>            (while
>                ;; If we are too near EOB, try scrolling the previous window.
> -              (condition-case nil (progn (scroll-up arg) nil)
> +              (condition-case nil (progn (scroll-up-command arg) nil)
>                  (end-of-buffer
>                   (condition-case nil (progn (follow-previous-window) t)
>                     (error
> @@ -551,12 +551,12 @@ (defun follow-scroll-down (&optional arg)
>  Works like `scroll-down' when not in Follow mode."
>    (interactive "P")
>    (cond ((not follow-mode)
> -        (scroll-down arg))
> +        (scroll-down-command arg))
>         ((eq arg '-)
>          (follow-scroll-up))
>         (t
>          (let ((opoint (point)))
> -          (scroll-down arg)
> +          (scroll-down-command arg)
>            (unless (and scroll-preserve-screen-position
>                         (get this-command 'scroll-command))
>              (goto-char opoint))
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#21893: 25.0.50; Using scroll-*-command in follow-mode
>
>
>
>
> Date: 
>
> Sun, 29 Sep 2019 23:40:04 +0200
>
>
>
>
> Juri Linkov <address@hidden> writes:
>
> > So now after installing scroll-error-top-bottom handling to master,
> > I'm closing this report.
>
> Seems like this was left open by mistake; closing now.
>
> Best regards,
> Stefan Kangas
>
>
> --- End Message ---