[debbugs-tracker] bug#36763: closed (`guix search` does unexpected logical and)

[GNU bug Tracking System]

Your message dated Thu, 19 Sep 2019 21:56:05 +0200
with message-id <address@hidden>
and subject line Re: bug#36763: `guix search` does unexpected logical and
has caused the debbugs.gnu.org bug report #36763,
regarding `guix search` does unexpected logical and
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
36763: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36763
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: `guix search` does unexpected logical and Date: Mon, 22 Jul 2019 19:11:50 +0200

Dear,

As discussed here [1], the `relevance` in `guix/ui.scm` does not match
"inter-field".

Attached a fix.
Now,  the example from the manual
  $ guix search crypto library | \
        recsel -e '! (name ~ "^(ghc|perl|python|ruby)")' -p name,synopsis
outputs the expected crypto libraries as `libb2`.


Please comment. :-)


Then, please indicate me how the commit has to be filled.
The commit 8874faaaac665100a095ef25e39c9a389f5a397f introducing the
logical AND says:

ui: 'relevance' considers regexps connected with a logical and.

* guix/ui.scm (relevance)[score]: Change to return 0 when one of REGEXPS
doesn't match.
* tests/ui.scm ("package-relevance"): New test.

Should another test be added?


[1] https://lists.gnu.org/archive/html/guix-devel/2019-07/msg00263.html


Thank you in advance,
simon

search.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#36763: `guix search` does unexpected logical and
>
>
>
>
> Date: 
>
> Thu, 19 Sep 2019 21:56:05 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
>
>
>
>
> Hello,
>
> zimoun <address@hidden> skribis:
>
> > On Mon, 16 Sep 2019 at 10:17, Ludovic Courtès <address@hidden> wrote:
> >
> >> Bonus points if you send the patch with ‘git format-patch’ and with a
> >> commit log:
> >
> > I did my best here:
> > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37448
> >
> > Hope I am doing right.
>
> Yup!
>
> We can close it now, thank you.
>
> Ludo’.
>
>
> --- End Message ---