[debbugs-tracker] bug#36896: closed (Evolution needs gsettings-desktop-schemas)

[GNU bug Tracking System]

Your message dated Mon, 16 Sep 2019 12:26:46 +0200
with message-id <87h85c1qqh.fsf@nckx>
and subject line Re: bug#36896: [PATCH] added gsettings-desktop-schema to 
progragated inputs
has caused the debbugs.gnu.org bug report #36896,
regarding Evolution needs gsettings-desktop-schemas
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
36896: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36896
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Evolution needs gsettings-desktop-schemas
>
>
>
>
> Date: 
>
> Thu, 1 Aug 2019 17:14:49 -0500
>
>
>
>
> Evolution will crash immediate if gsettings-desktop-schemas is not also
> installed
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#36896: [PATCH] added gsettings-desktop-schema to progragated inputs Date: Mon, 16 Sep 2019 12:26:46 +0200

Martin,

Martin Becze 写道：

ping :P

Absolutely.

The diff you sent here[0] is incomplete (it relies on your previous patch and doesn't have a header); please always send git-formatted patches that apply directly to current master. They are easier to merge and will be merged sooner.

Yeah I don't know. I just used prefix in the latest patch. Let me know

if the other method is preferred.

¯\_(ツ)_/¯

I've pushed this to master as ad6e168b3f29576d92b00725dedbb38cd5f05e46 with the following changes:

- Moved widowed ‘#:phases’ to the previous line (in well-formatted Scheme, ‘(’ can never end a line and ‘)’ should never start one), same for 'phase 'names - then decided to move ’#:phases’ below ‘#:configure-flags’. This is subjective, but since *flags ‘affect’ phases (never the other way 'round) it felt right :-)

- dropped the unused ‘inputs’ phase argument

- added the missing ":" separator to the prefix wrapping — if it does work without one (I didn't test), that's undocumented & shouldn't be relied upon

- removed unnecessary trailing / in ‘schemas/’

- and wrote a commit message as mostly documented in ‘info (standards)Change Logs’.

Thanks!

T G-R

[0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36896#53

signature.asc
Description: PGP signature

--- End Message ---