[debbugs-tracker] bug#37318: closed (OpenNTPD generated config is convoluted)

[GNU bug Tracking System]

Your message dated Tue, 10 Sep 2019 13:04:21 +0900
with message-id <address@hidden>
and subject line Re: bug#37318: [PATCH] OpenNTPD generated config is convoluted
has caused the debbugs.gnu.org bug report #37318,
regarding OpenNTPD generated config is convoluted
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
37318: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37318
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> OpenNTPD generated config is convoluted
>
>
>
>
> Date: 
>
> Tue, 03 Sep 2019 13:33:42 +0900
>
>
>
>
> For the documented following openntpd-service-type definition:
>
> --8<---------------cut here---------------start------------->8---
> (openntpd-configuration
>             (listen-on '("127.0.0.1" "::1"))
>             (sensor '("udcf0 correction 70000"))
>             (constraint-from '("www.gnu.org"))
>             (constraints-from '("https://www.google.com/";))
>             (allow-large-adjustment? #t)))
> --8<---------------cut here---------------end--------------->8---
>
> The following configuration file is generated:
>
> --8<---------------cut here---------------start------------->8---
> listen on 127.0.0.1
>  listen on ::1
> constraints from "https://www.google.com/";
> constraints from "https://www.google.com/";
> sensor udcf0 correction 70000
> constraints from "https://www.google.com/";
> server 0.guix.pool.ntp.org
>  server 1.guix.pool.ntp.org
>  server 2.guix.pool.ntp.org
>  server 3.guix.pool.ntp.org
> constraints from "https://www.google.com/";
> constraints from "https://www.google.com/";
> constraint from www.gnu.org
> --8<---------------cut here---------------end--------------->8---
>
> Notice the repeated "constraints from" directives.
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#37318: [PATCH] OpenNTPD generated config is convoluted
>
>
>
>
> Date: 
>
> Tue, 10 Sep 2019 13:04:21 +0900
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
>
>
>
>
> Hello,
>
> Efraim Flashner <address@hidden> writes:
>
> > On Sat, Sep 07, 2019 at 01:21:27PM +0900, Maxim Cournoyer wrote:
> >> Hello,
> >> 
> >> The attached patches fix this issue as well as the openntpd package not
> >> being able to load the CA cert used to authenticate constraint servers.
> >> 
> >> It depends on the NTP patches posted here: bugs.gnu.org/37295.
> >> 
> >
> > This set also looks good to me. Make sure you don't forget any copyright
> > lines for yourself.
>
> I thought I had answered already, but it seems my reply wasn't sent.
>
> Fixed in commit cccdfae388d61f2263a085a4ddac8cb2919d01531.  Thanks for
> the review!
>
> Maxim
>
>
> --- End Message ---