--- Begin Message ---
Subject: |
Package-Requires should support multiple lines |
Date: |
Wed, 19 Jun 2019 21:55:27 -0400 |
Hi,
The Package-Requires line in my GNU ELPA package, Excorporate, is much
longer than 80 characters and I would like to wrap it. It would be nice
if package.el allowed Package-Requires to span multiple lines (see
patch). It's probably too late to change this but I thought I'd file a
bug report anyway.
Thomas
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 46f7c91272..5c9b12732d 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1016,7 +1016,8 @@ package-buffer-info
(narrow-to-region start (point))
(require 'lisp-mnt)
;; Use some headers we've invented to drive the process.
- (let* ((requires-str (lm-header "package-requires"))
+ (let* ((requires-str
+ (mapconcat 'identity (lm-header-multiline "package-requires") " "))
;; Prefer Package-Version; if defined, the package author
;; probably wants us to use it. Otherwise try Version.
(pkg-version
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#36301: Package-Requires should support multiple lines |
Date: |
Sun, 01 Sep 2019 13:34:23 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Thomas Fitzsimmons <address@hidden> writes:
> Noam Postavsky <address@hidden> writes:
>
>> Thomas Fitzsimmons <address@hidden> writes:
>>> I wonder if there's a better way to do the equivalent of mapconcat but
>>> produce nil on a nil input sequence.
>>
>> Not exactly, but I think this is good place for and-let*:
>
> Yes, looks good; "make check" passes on these tests, so I pushed this
> new patch. I'll wait for other test results before closing this.
The Hydra build succeeded too:
https://hydra.nixos.org/build/99577710
so I'm closing this.
Thanks,
Thomas
--- End Message ---