[debbugs-tracker] bug#35999: closed ([PATCH] gnu: add gthumb)

[GNU bug Tracking System]

Your message dated Thu, 30 May 2019 11:51:35 +0200
with message-id <address@hidden>
and subject line Re: [bug#35999] [PATCH] gnu: add gthumb
has caused the debbugs.gnu.org bug report #35999,
regarding [PATCH] gnu: add gthumb
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
35999: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35999
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: add gthumb
>
>
>
>
> Date: 
>
> Thu, 30 May 2019 00:02:38 -0700
>
>
>
>
> From: Andy Tai <address@hidden>
>
>  * gnu/packages/gnome.scm (gthumb): Add at 3.8.0
> ---
>  gnu/packages/gnome.scm | 40 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 14e63280ed..e1aa6c6fc5 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -7974,3 +7974,43 @@ functionality.")
>      (license (list license:lgpl2.1 license:lgpl3 ; either one of these
>                     license:openldap2.8 ; 
> addressbook/gui/component/openldap-extract.h
>                     license:lgpl2.1+))))  ; smime/lib/*
> +
> +
> +(define-public gthumb
> +  (package
> +    (name "gthumb")
> +    (version "3.8.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://gnome/sources/gthumb/"
> +                                  (version-major+minor version) "/"
> +                                  "gthumb-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "1l2s1facq1r6yvqjqc34aqfzlvb3nhkhn79xisxbbdlgrrxdq52f"))))
> +    (build-system meson-build-system)
> +    (arguments
> +     `(#:validate-runpath? #f))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("glib:bin" ,glib "bin")         ; For glib-compile-resources
> +       ("gtk+:bin" ,gtk+ "bin")         ; For gtk-update-icon-cache
> +       ("desktop-file-utils" ,desktop-file-utils) ; for update-desktop-database
> +       ("intltool" ,intltool)
> +       ("itstool" ,itstool)))
> +    (inputs
> +     `(("exiv2" ,exiv2)
> +       ("gtk" ,gtk+)
> +       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
> +       ("gstreamer" ,gstreamer)
> +       ("clutter" ,clutter)
> +       ("clutter-gst" ,clutter-gst)
> +       ("clutter-gtk" ,clutter-gtk)
> +       ("libjpeg" ,libjpeg)
> +       ("libtiff" ,libtiff)
> +       ("libraw" ,libraw)))
> +    (synopsis "GNOME image viewer and browser")
> +    (description "GThumb is an image viewer, browser, organizer, editor and
> +advanced image management tool")
> +    (home-page "https://wiki.gnome.org/Apps/Ghex";)
> +    (license license:gpl2+)))
> -- 
> 2.20.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#35999] [PATCH] gnu: add gthumb
>
>
>
>
> Date: 
>
> Thu, 30 May 2019 11:51:35 +0200
>
>
>
>
> User-agent: 
>
> mu4e 1.2.0; emacs 26.2
>
>
>
>
> Ricardo Wurmus <address@hidden> writes:
>
> > Hi Andy,
> >
> >>  * gnu/packages/gnome.scm (gthumb): Add at 3.8.0
> >
> > thanks for the patch.
> >
> > (Note that the commit message should be “Add variable.”)
> >
> >
> >> +    (arguments
> >> +     `(#:validate-runpath? #f))
> >
> > It’s not a good idea to disable RUNPATH validation, because it usually
> > shows you that something might be wrong.  In this package the problem is
> > that the RUNPATH does not include the lib/gthumb/extensions
> > directory.
> >
> > I’m still fighting with a handful of binaries that don’t seem to get the
> > right RUNPATH, but once that’s done I’ll push the updated patch to the
> > master branch.
>
> Pushed to the master branch with commit 169d63f533.
> I fixed the RUNPATH problems and made sure the application doesn’t crash
> with a GLib-GIO-ERROR error by adding #:glib-or-gtk? #t.
>
> -- 
> Ricardo
>
>
>
> --- End Message ---