--- Begin Message ---
Subject: |
[PATCH] gnu: milkytracker: Actually link with the JACK library. |
Date: |
Sun, 18 Feb 2018 14:50:49 -0500 |
* gnu/packages/music.scm (milkytracker)[arguments]: Add appropriate configure
flag.
---
gnu/packages/music.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 3709f10d1..e88c9f21f 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -2609,7 +2609,8 @@ of tools for manipulating and accessing your music.")
(("add_subdirectory\\(resources/music\\)") ""))))))
(build-system cmake-build-system)
(arguments
- '(#:tests? #f)) ; no check target
+ '(#:tests? #f ; no check target
+ #:configure-flags '("-DCMAKE_CXX_FLAGS=-ljack")))
(inputs
`(("alsa-lib" ,alsa-lib)
("jack" ,jack-1)
--
2.16.1
--- End Message ---
--- Begin Message ---
Subject: |
Re: [bug#30517] [PATCH] gnu: milkytracker: Actually link with the JACK library. |
Date: |
Thu, 08 Mar 2018 10:11:55 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
address@hidden (Ludovic Courtès) writes:
> Kei Kebreau <address@hidden> skribis:
>
>> * gnu/packages/music.scm (milkytracker)[arguments]: Add appropriate configure
>> flag.
>> ---
>> gnu/packages/music.scm | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
>> index 3709f10d1..e88c9f21f 100644
>> --- a/gnu/packages/music.scm
>> +++ b/gnu/packages/music.scm
>> @@ -2609,7 +2609,8 @@ of tools for manipulating and accessing your music.")
>> (("add_subdirectory\\(resources/music\\)") ""))))))
>> (build-system cmake-build-system)
>> (arguments
>> - '(#:tests? #f)) ; no check target
>> + '(#:tests? #f ; no check target
>> + #:configure-flags '("-DCMAKE_CXX_FLAGS=-ljack")))
>
> I’d suggest adding a comment as to why this is needed.
>
> Then I think you can go ahead and push it. If it fixes a use case for
> you, that’s already an improvement.
>
> Thanks,
> Ludo’.
Pushed with added comment. Thanks for reviewing!
signature.asc
Description: PGP signature
--- End Message ---