[debbugs-tracker] bug#11706: closed (24.1.50; Wrong behavior of move-end-of-line in ERC)

[GNU bug Tracking System]

Your message dated Sat, 06 Oct 2012 21:41:30 -0400
with message-id <address@hidden>
and subject line Re: bug#11706: 24.1.50; Wrong behavior of move-end-of-line in 
ERC
has caused the debbugs.gnu.org bug report #11706,
regarding 24.1.50; Wrong behavior of move-end-of-line in ERC
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
11706: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11706
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 24.1.50; Wrong behavior of move-end-of-line in ERC
>
>
>
>
> Date: 
>
> Thu, 14 Jun 2012 09:48:20 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)
>
>
>
>
> Hi,
>
> (setq erc-timestamp-only-if-changed-flag nil
>       erc-hide-timestamps t
>       erc-insert-timestamp-function 'erc-insert-timestamp-left)
>
> Join IRC, type a few line, then go back in the text and type C-e. Point
> will stop one character before EOL. It's annoying.
>
> My quick fix is
> diff --git a/lisp/erc/erc-stamp.el b/lisp/erc/erc-stamp.el
> index 5831233..b43b2b3 100644
> --- a/lisp/erc/erc-stamp.el
> +++ b/lisp/erc/erc-stamp.el
> @@ -352,7 +352,7 @@ Return the empty string if FORMAT is nil."
>                                'isearch-open-invisible 'timestamp ts)
>         ;; N.B. Later use categories instead of this harmless, but
>         ;; inelegant, hack. -- BPT
> -       (when erc-timestamp-intangible
> +       (when (and erc-timestamp-intangible (not erc-hide-timestamps))
>           (erc-put-text-property 0 (length ts) 'intangible t ts))
>         ts)
>      ""))
>
> I think it's fine to install in trunk and certainly unlikely to cause
> any further bugs (there's not much point in setting something invisible
> as intangible), but I don't know very well how the code works, so I'd
> appreciate it if someone could review it and fix the whole thing
> consistently.
>
> Antoine
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#11706: 24.1.50; Wrong behavior of move-end-of-line in ERC
>
>
>
>
> Date: 
>
> Sat, 06 Oct 2012 21:41:30 -0400
>
>
>
>
> User-agent: 
>
> Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
>
>
>
>
> Version: 24.3
>
> Thanks; applied to trunk.
>
>
> --- End Message ---