[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Duplicity-tracker] [patch #6806] More graceful handling of old --short-

From: Michael Terry
Subject: [Duplicity-tracker] [patch #6806] More graceful handling of old --short-filename files
Date: Sun, 12 Apr 2009 18:20:17 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/2009033100 Ubuntu/9.04 (jaunty) Firefox/3.0.8


                 Summary: More graceful handling of old --short-filename
                 Project: duplicity
            Submitted by: mikix
            Submitted on: Sun 12 Apr 2009 02:20:15 PM EDT
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any



So in 0.5.10, the file naming was changed to make --short-filenames and
--time-separator unnecessary.  Duplicity recognizes the old-style filenames
and will write new files with the new-style.  So one chain will have both
old-style and new-style names.

This is great.  It provides a graceful way to migrate to new style without
creating a new backup chain.

However, the same graceful migration was not done for any existing
--short-filenames ("short") files.  This causes the user to continue to use
the --short-filenames option until they make a new fresh backup.  And
even/once they do, if they want to restore from old chain, they have to
remember to use --short-filenames.

This patch makes duplicity recognize short files even if short filenames is
not specified explicity.  It allows a graceful migration to the new naming
scheme for any short filename users.

You may wonder why bother at this point, 0.5.10 has been out for a while,
anyone affected probably already went to the new scheme:

1) Lets anyone still using --short-filenames just drop it and have everything
still work.  I think this patch should be a prerequisite before you ever
actually remove the --short-filenames option (as indicated will happen due to
the deprecation).

2) Not everyone has moved to 0.5.10.  Notably, Ubuntu 9.4 will ship with
0.5.09 and all Ubuntu users will be bitten by this naming change once 9.10
comes out.

3) Deja Dup can't gracefully migrate users that backup to FAT devices without
this change.  Right now, Deja Dup first checks if the user has any short files
already there, and passes --short-filenames if any are.  I would like to drop
this and just never user --short-filenames to migrate to new file naming
scheme and reduce this complexity.

There's a bzr branch for this at
'lp:~mterry/duplicity/graceful-short-filenames'.  Is that useful?  The
attached patch was created by using bzr diff on the two branches.


File Attachments:

Date: Sun 12 Apr 2009 02:20:15 PM EDT  Name: graceful-short-filenames.patch 
Size: 7kB   By: mikix



Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]