[Duplicity-tracker] [patch #6696] Consolidate get_delta_iter and get_delta_iter_w_sig

[Michael Terry]

URL:
  <http://savannah.nongnu.org/patch/?6696>

                 Summary: Consolidate get_delta_iter and get_delta_iter_w_sig
                 Project: duplicity
            Submitted by: mikix
            Submitted on: Mon 15 Dec 2008 12:35:53 AM EST
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

get_delta_iter and get_delta_iter_w_sig are very similar.  It appears that
the w_sig is the newer version, and since it appeared, get_delta_iter has
bit-rotten.

I revived get_delta_iter with the --dry-run option, and have noticed at least
one bug:  duplicity will exception out if while iterating (new_path,
sig_path), it hits (not new_path and not sig_path.exists()).

This was fixed in the w_sig version, but never in the normal version.

To avoid any bit-rotting in the future, here's a patch to consolidate both
functions into one.  I had to convert get_delta_path too.

I tested both with and without --dry-run a bit, but since this loop is so
important, obviously please scour this patch for any typos.  :)



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 15 Dec 2008 12:35:53 AM EST  Name: w_sig.diff  Size: 9kB   By:
mikix

<http://savannah.nongnu.org/patch/download.php?file_id=17067>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6696>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/