[Duplicity-tracker] [patch #6694] Log exceptions

[Michael Terry]

URL:
  <http://savannah.nongnu.org/patch/?6694>

                 Summary: Log exceptions
                 Project: duplicity
            Submitted by: mikix
            Submitted on: Sun 14 Dec 2008 08:54:13 PM EST
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Exceptions currently don't go through the logger.  This means that wrappers
don't know why duplicity just exited with status 1.

Here's a patch to make them do so.  It gives the same output as before, but
it logs a message (and puts the exception class on the control line for the
consumer).

I also changed the printing of UserExceptions to not print a list of strings,
but rather one big string.  I think this was a typo.  I also added the same
exception class info the machine-readable output for UserExceptions, since it
seemed useful to know.

Further, I added a little line in FatalError to call log.shutdown() right
before exiting.  There weren't any problems with the current logging backends
if we didn't, but it seemed like the right thing to do (the logging module
documentation suggests that some logging backends don't always flush
immediately?).

This patch is on top of the previous 'finish adding codes to all FatalError
calls in the backends'



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 14 Dec 2008 08:54:13 PM EST  Name: exception.diff  Size: 2kB   By:
mikix

<http://savannah.nongnu.org/patch/download.php?file_id=17064>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6694>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/