[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Duplicity-tracker] [patch #6380] add additional named logging levels

From: Peter Schuller
Subject: [Duplicity-tracker] [patch #6380] add additional named logging levels
Date: Tue, 22 Jan 2008 18:47:27 +0000
User-agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv: Gecko/20071215 Firefox/

Follow-up Comment #2, patch #6380 (project duplicity):

Sounds good to me. I propose the following:

(1) First, re-define the existing logging functions to use the logging API,
but do not yet make changes to levels or other places in the code to use the
python logging API.

(2) Make sure this doesn't somehow affect people over a release or so.

(3) Now, or before (2), provide a way to configure the logging target (for
example, a common usa case might be to have warnings/errors logged to syslog,
but the rest only logged on the console).

(4) When satisfies it does not cause issues, start changing various code to
use the logging API natively, or alternatively through a thin wrapper that
more directly map to the logging API. 

The last point would entail also establishing a standard for logger names.
For example, one convention I have used in the past, is to use the fully
qualified class name when logging from instances, and the module name when
logging from functions or at the top level (no function name because I could
not find a way to obtain that information without a lot of code at the call

Does that sound reasonable?


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]