[Duplicity-tracker] [bug #21909] Problematic typo in compare_verbose() method

[anonymous]

URL:
  <http://savannah.nongnu.org/bugs/?21909>

                 Summary: Problematic typo in  compare_verbose()  method
                 Project: duplicity
            Submitted by: None
            Submitted on: Sunday 12/30/2007 at 08:17 UTC
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

On line 297 of  duplicity/path.py  (rev 1.15 == HEAD) in the method 
compare_verbose()  the following appears:

  if self.isreg() or self.isdir or self.isfifo():

This will always evaluate to true because of the missing parentheses after 
self.isdir,  and hence, when verifying, causes differences to be printed when
there are none.  The obvious fix is to call  self.isdir()  properly:

  if self.isreg() or self.isdir() or self.isfifo():

Hope this is helpful.

Regards,
Hamish.




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?21909>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/