[Duplicity-tracker] [bug #21896] Two problems with rsync under 0.4.8 + patch

[Kenneth Loafman]

URL:
  <http://savannah.nongnu.org/bugs/?21896>

                 Summary: Two problems with rsync under 0.4.8 + patch
                 Project: duplicity
            Submitted by: loafman
            Submitted on: Wednesday 12/26/2007 at 18:36
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: In Progress
                 Privacy: Public
             Assigned to: loafman
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Alexander Zangerl <address@hidden> in an email wrote:

the bad news: i've just run into two major oopses concerning 
the rsync backend, which make the rsync backend currently unusable and
dangerous to use. this applies to both 0.4.7 and .8.
the good news: i've found the problems and a patch is attached.

* non-module rsync urls do not work anymore in 0.4.8.

$ duplicity  full -v9 --encrypt-key 42BD645D  
  --archive-dir /tmp/arch src/spam-stuff/ rsync://address@hidden/u
Main action: full
Reading results of 'rsync address@hidden/'

the / between hostname and path is lost, and obviously rsync is badly
confused. the easy fix is to distinguish properly between non-module urls
(which need to retain the /) and module-urls (which mustn't).

* the second full backup destroys all stored backups, without any 
error indication!

here's the sequence of events that i used to reproduce this problem:

$ duplicity  full --encrypt-key 42BD645D --archive-dir /tmp/arch 
  src/spam-stuff/ rsync://address@hidden::/backup/test/ 

tosspot is my backup box, /backup is the rsync module.
backup status after this full run:
$ ls -l
total 96
-rw------- 1 backup backup  8825 Dec 21 16:29
duplicity-full-signatures.2007-12-21T16:29:55+10:00.sigtar.gpg
-rw------- 1 backup backup   630 Dec 21 16:29
duplicity-full.2007-12-21T16:29:55+10:00.manifest.gpg
-rw------- 1 backup backup 75889 Dec 21 16:29
duplicity-full.2007-12-21T16:29:55+10:00.vol1.difftar.gpg

all is good, so far. 5 minutes later i run another full backup with the same
commandline plus -v9.

and now the backup status is shot:
$ ls -la
total 28
drwxr-xr-x 2 backup backup 4096 Dec 21 16:32 .
drwxr-xr-x 9 root   root   4096 Dec 21 15:33 ..
-rw------- 1 backup backup   63 Dec 21 16:32
duplicity-full-signatures.2007-12-21T16:31:59+10:00.sigtar.gpg
-rw------- 1 backup backup   54 Dec 21 16:32
duplicity-full.2007-12-21T16:29:55+10:00.manifest.gpg
-rw------- 1 backup backup   58 Dec 21 16:32
duplicity-full.2007-12-21T16:29:55+10:00.vol1.difftar.gpg
-rw------- 1 backup backup   54 Dec 21 16:32 
duplicity-full.2007-12-21T16:31:59+10:00.manifest.gpg
-rw------- 1 backup backup   58 Dec 21 16:32
duplicity-full.2007-12-21T16:31:59+10:00.vol1.difftar.gpg

all files are ascii text, containing just their own file names:
$ cat duplicity-full.2007-12-21T16:31:59+10:00.vol1.difftar.gpg 
duplicity-full.2007-12-21T16:31:59+10:00.vol1.difftar.gpg

i've identified the problem: the don't-remove-these tempfile (exclude_name)
is never written to. 0.4.3 has the right code sequence, 
   print >>exclude, file
but 0.4.7 and onwards
    print f, file
which produces an empty exclude file and broken files containing only their
own names. patch attached. 
(why you open-close files that won't be synced in the first place 
is not really obvious to me...)

patch against 0.4.8 attached.




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wednesday 12/26/2007 at 18:36  Name: 03_rsync.dpatch  Size: 1kB   By:
loafman

<http://savannah.nongnu.org/bugs/download.php?file_id=14707>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?21896>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/