[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Duplicity-tracker] [patch #6353] Concurrency for volume encryption and
From: |
Kenneth Loafman |
Subject: |
[Duplicity-tracker] [patch #6353] Concurrency for volume encryption and upload. |
Date: |
Tue, 25 Dec 2007 13:54:35 +0000 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.11) Gecko/20060601 Firefox/2.0.0.11 (Ubuntu-edgy) |
Follow-up Comment #6, patch #6353 (project duplicity):
This is beginning to look good. A couple of comments...
1) I'm moving to the PEP-8 guidelines for code style. As I add code or
modify a module, I'm gradually getting rid of the old multi-statement per line
style. From now on, please add a newline and indent to any statement (if,
for, while, try, etc.). This makes it easier to read and debug.
2) Yes, please move the threading to a separate module. It would be the
start of refactoring the code. I'm thinking of making the backends a module
with separate files for each protocol, so this would help.
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?6353>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/