[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Duplicity-tracker] [patch #6299] re-design tempfile handling
From: |
Peter Schuller |
Subject: |
[Duplicity-tracker] [patch #6299] re-design tempfile handling |
Date: |
Sat, 01 Dec 2007 20:54:28 +0000 |
User-agent: |
Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.8.1.8) Gecko/20071030 Firefox/2.0.0.8 |
Follow-up Comment #1, patch #6299 (project duplicity):
Note that as far as I am aware there should be no security issues with this
code under "normal" circumstances.
Things are not perfect in the presence of tmpwatch/tmpreaper and similar, but
still a lot better than before.
Further work would include making use of mkstemp() whenever mktemp() is
currently being used, to squash all security issues.
However, as I noted in the original patch that broke FTP, using mkstemp()
semantics required some changes in various places. Maybe I'll look into it in
the future.
Also note that this version should now be much better at cleaning up after
itself compared to the old code, because cleanup is now always performed even
if exceptions are thrown.
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?6299>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/