Re: [Dr. Geo] Dr Geo new build errors on the Mac

[Oscar Nierstrasz]

Actually a precondition is always local and cannot be affected by future code evolution. This particular precondition might simply always be fulfilled, as it will in the case of your solution, but it will do  no harm. (The cost of the check is insignificant.)

Cheers,

Oscar
---
oscar.nierstrasz@feenk.com
https://feenk.com/about/

On 3 Apr 2024 at 11:55 +0200, Hilaire Fernandes <hfern@free.fr>, wrote:

Hi Oscar,

Thanks for the suggestion. I changed it differently https://github.com/hilaire/drgeo/issues/27.

The precondition to iconsPath may not resist to future code evolution. Think about future code changes where the plateform variable is accessed from another method and "earlier" than #iconPath. Also I want to avoid the overload to the access method.

I am not sure you need to adjust your command build script, I don't think so.

We should add it to the repo by the way.

Hilaire

Le 03/04/2024 à 09:55, Oscar Nierstrasz a écrit :

Can I suggest adding the following precondition to iconsPath? It would make clear what the problem is if someone “forgets” to initialize DrGeo.

DrGeoSystem>>#iconsPath
self assert: platform notNil description: 'DrGeo must be initialized.
Run `DrGeoSystem beDevelopment.` or `DrGeoSystem beWorkstation.`'.
^ platform iconsPath

--  
GNU Dr. Geo
http://gnu.org/s/dr-geo/
http://gnu-drgeo.blogspot.com/