[Pnet-developers] [patch #3110] unnecessary thread creation when doing threadpool completion units

[Gopal.V]

This mail is an automated notification from the patch tracker
 of the project: DotGNU Portable.NET.

/**************************************************************************/
[patch #3110] Latest Modifications:

Changes by: 
                Gopal.V <address@hidden>
'Date: 
                Mon 05/31/2004 at 13:46 (Asia/Calcutta)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Invalid
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
This patch is invalid (as said by the author himself)






/**************************************************************************/
[patch #3110] Full Item Snapshot:

URL: <http://savannah.gnu.org/patch/?func=detailitem&item_id=3110>
Project: DotGNU Portable.NET
Submitted by: David Logan
On: Mon 05/31/2004 at 01:42

Category:  None
Priority:  3 - Low
Resolution:  Invalid
Assigned to:  None
Originator Email:  
Status:  Closed


Summary:  unnecessary thread creation when doing threadpool completion units

Original Submission:  The routine that added "completion units to do" to the 
list also checked to see if a new completion thread needed to be started. It 
was starting a new thread when there were completion units to be done and there 
were less completion threads than the max available (with no regard to how many 
currently active completion threads were waiting for work.) I just added a 
check so that new threads would not be created unless all currently created 
threads were busy.

Follow-up Comments
------------------


-------------------------------------------------------
Date: Mon 05/31/2004 at 13:46       By: t3rmin4t0r
This patch is invalid (as said by the author himself)

-------------------------------------------------------
Date: Mon 05/31/2004 at 04:37       By: djlogan
DO NOT APPLY THIS PATCH. IT WILL NOT WORK. By limiting thread creation, it is 
possible that completion units will wait in the wait queue for existing threads 
to come process work.

Well, it can be true that completion units are dependent upon other completion 
units, and we don't want the dependents to be in the wait queue waiting for 
threads that depend on them to execute. Results: Deadlock.

-------------------------------------------------------
Date: Mon 05/31/2004 at 02:36       By: djlogan
Submitting a new patch. The previous one was erroneously submitted with a 
syntax error in it.






File Attachments
-------------------

-------------------------------------------------------
Date: Mon 05/31/2004 at 02:36  Name: root-040530.threadpool.patch  Size: 937KB  
 By: djlogan
New patch without syntax error
http://savannah.gnu.org/patch/download.php?item_id=3110&amp;item_file_id=3326

-------------------------------------------------------
Date: Mon 05/31/2004 at 01:42  Name: root-040530.threadpool.patch  Size: 1KB   
By: djlogan
threadpool patch for completion threads
http://savannah.gnu.org/patch/download.php?item_id=3110&amp;item_file_id=3325






For detailed info, follow this link:
<http://savannah.gnu.org/patch/?func=detailitem&item_id=3110>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/