Re: RE : RE : [Pnet-developers] System.NotImplementedException when implementing Environment.GetSpecialFolder

[Gopal V]

If memory serves me right, Yannis BRES wrote:
>     That patch is at
> http://savannah.gnu.org/patch/?func=detailpatch&patch_id=1760&group_id=353.

Great work ! ... I really appreciate the work you've put into defining
all the macros and working out the win32 calls .

But in fitting in with "Portable.net" motto , I do think this needs a
lot of re-ordering of code before I commit it 2 days before a release.
I hate it when Rhys or someone rewrites my patches , but it just has
to get cleaner as we reach near the release dates . So I hope you won't
mine me juggling with your functions , names etc... keeping the logic
the same ?

So consider this a guided tour of the Portable.net system for the 
first time visitor ;-)

+#else
+  /* TODO for non-Win32 OSes */
+  return null;
+#endif

was supposed to return NULL;

Ok, also another Portable.net policy is to never #ifdef a platform inside
the internal calls , all the system specific code should be moved to the 
support/ directory. Before I commit this code , I'll do so and create a 
new ILPathGetSpecialFolder() function.

Also the IL_SP_* stuff is better done as (a set of macros + set of enums)
due to 2 reasons . A macro is for communication between engine and support.
And the enum for engine and C# . Also gcc does give better error
checking when handling enums in switch statement . Also this will be 
similar to the general design of the rest of the enums used in lib_*.c 
files , for an API coherence.

If the platform does not have GetFolder support , we run into an 
important problem . Figuring that out is point #2 though.. see my
reply to Pascal Hauser's mail.

In short, a heavily security & portable hardened copy of your patch 
will enter CVS shortly :)

Gopal
-- 
The difference between insanity and genius is measured by success