[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Dolibarr-dev] Bug in htdocs/comm/mailing/cibles.php on line 310
From: |
Marc-Henri Pamiseux |
Subject: |
[Dolibarr-dev] Bug in htdocs/comm/mailing/cibles.php on line 310 |
Date: |
Wed, 22 May 2013 23:20:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 |
Hi,
I've got a bug in a mailing.
Warning: Missing argument 1 for
mailing_thirdparties_services_expired::getNbOfRecipients(), called in
{...}htdocs/comm/mailing/cibles.php on line 310 and defined in
{...}htdocs/core/modules/mailings/thirdparties_services_expired.modules.php
on line 182
With the last pull of branch 3.3 in git repository, the file cibles.php
call getNbOfRecipients() in line 310 without the first argument.
In
htdocs/core/modules/mailings/thirdparties_services_expired.modules.php i
can see this definition :
function getNbOfRecipients($sql,$filter=1,$option='')
{
...
$a=parent::getNbOfRecipients($sql);
return $a;
}
I think there must be a NULL default value for the first argument,
something like :
function getNbOfRecipients($sql='',$filter=1,$option='')
{
might be better ?
Most of the time, this function getNbOfRecipients() is defined like
function getNbOfRecipients($sql=''), except in the line N°79 in
core/modules/mailings/modules_mailings.php and at line N°182 in
core/modules/mailings/thirdparties_services_expired.modules.php.
In fact, only comm/mailing/cibles.php at line 310 call this
getNbOfRecipients function without any argument.
Could you commit this change in GIT repo ?
Best regards,
--
Marc-Henri Pamiseux - SARL Libricks - www.libricks.fr
6 rue Léonard de Vinci - CS 20119, 53001 LAVAL Cedex
Tel. : 02.30.96.15.24 / Mobile : 06.26.71.30.97
signature.asc
Description: OpenPGP digital signature
- [Dolibarr-dev] Bug in htdocs/comm/mailing/cibles.php on line 310,
Marc-Henri Pamiseux <=