|
From: | Florian Henry |
Subject: | [Dolibarr-dev] PHP code sniffer custom |
Date: | Tue, 09 Apr 2013 16:14:45 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
Hello all, As de devcamp coming soon, I start to review code quality with PHP Code Sniffer (as describe into wiki optionnal tools pages). I'm actually reviwing the note/private/public code (task 811) and projet module (task 772). During this review I see some strange code like "and" instead of "&&" into if test statement or for array "$array[code]" instead of "$array['code']". The PHP Code Sniffer show it immediatly and it's easy to correct. This mail is to know if somebody know how to personnalize a little more the file dev/codesniffer/ruleset.xml to add a rule to say that $_POST or $_GET have to be replace by GETPOST dolibarr function ? Kind regards -- Florian HENRY address@hidden +33 6 03 76 48 07 http://www.open-concept.pro Twitter : @_Open_Concept_ |
[Prev in Thread] | Current Thread | [Next in Thread] |