Le 18/07/2011 19:36, CF a écrit :
Hello Doli,
First, this is my first message. Aka Graveen, i was project
manager and sysadmin of a enginneering company. Actually running
my own business, i'm consulted by many little society to rethink
their information system (network, systems) and bring them tools
(custom piece of software, formations, etc...)
In this scope, i have carefully choosen Dolibarr, because it
meets many of the requirements for a solid basis for small
society.
I generally develop in java (generally android), c# (.net /
mono), and sometimes in php / html for web-based tools
(generally frontend). I promote Linux server & client side,
and FOSS technology in general.
I'm also project leader of Dawn of Light, an open source Dark
Age of Camelot (MMORPG) emulator, written in C# and using MySQL
( http://www.dolserver.net )
That was the introduction. I sometimes meet Eldy on LinuxFr.org
, where i generally drop a line related to the Dolibarr project.
As i ask in some projects, i'll try to, during the customization
of Dolibarr, to simply think 'community' in the scope of my
devs.
Right now, i have implemented a system to add icons in the
custom top menu. I have two questions related to this:
1) my problem is current pictures are included via CSS and
background-image property, relying on a named class. I include
picture support into the html generation - which is obviously
not good because it overrides CSS one. Any idea on how i could
code something more compliant, or is it not a concern for
current Dolibarr ? For me CSS drives the display size, but not
the final image URL.
Not completely agree.
What drive display size AND image to show, are themes. All are into
theme/mytheme directory.
CSS is just a part of theme definition and images are the other
part.
But CSS and images should not be divided. We try to have all look
managed by themes.
2) i think all menus should be relying on the
icon system, rather than embed it in CSS. Actually, i accept URL
for icon, while the llx_menu table is including an icon field.
What about this point ? For all menus or only for custom menus ?
Menus are something that are dynamic and can be edited. Goal of menu
managers is not to define look but only menu label, menu orders and
menu conditions to show. That's why we can't have images defined by
menu. But menu can define a class and theme can then associate class
to image it wants to show.
3) my changes are applyed to eldy.lib.php. Guess
this should be either factored, or applyed to all xxx.lib.php. I
also don't know if this is breaking smartphone displaying.
I'm open to all changes that could be included into Dolibarr.
Thank you for your comment. Actually the described patch is ok
and - i think - Dolibarr's rules compliant.
Graveen
_______________________________________________
Dolibarr-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
--
Eldy (Laurent Destailleur).
---------------------------------------------------------------
EMail: address@hidden
Web: http://www.destailleur.fr
Dolibarr (Project leader): http://www.dolibarr.org
To make a donation for Dolibarr project via Paypal: address@hidden
AWStats (Author) : http://awstats.sourceforge.net
To make a donation for AWStats project via Paypal: address@hidden
AWBot (Author) : http://awbot.sourceforge.net
CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net
|