Re: [PATCH 3/3] dmidecode: Expand list of recognized port types

[Jean Delvare]

On Tue, 19 Dec 2023 01:43:26 +0100, Armin Wolf via dmidecode-devel wrote:
> On an Asus Prime B650-Plus motherboard, the thunderbold
> connector displays <OUT OF SPEC> due to it not recognizing
> the thunderbold port type.
> Fix this by expanding the list of port types to match
> the list specified in SMBIOS 3.7.0.
> 
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
>  dmidecode.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/dmidecode.c b/dmidecode.c
> index 73b2c3d..3cf9f91 100644
> --- a/dmidecode.c
> +++ b/dmidecode.c
> @@ -1985,14 +1985,16 @@ static const char *dmi_port_type(u8 code)
>               "Modem Port",
>               "Network Port",
>               "SATA",
> -             "SAS" /* 0x21 */
> +             "SAS",
> +             "MFDP (Multi-Function Display Port)",
> +             "Thunderbolt" /* 0x23 */
>       };
>       static const char *type_0xA0[] = {
>               "8251 Compatible", /* 0xA0 */
>               "8251 FIFO Compatible" /* 0xA1 */
>       };
> 
> -     if (code <= 0x21)
> +     if (code <= 0x23)
>               return type[code];
>       if (code >= 0xA0 && code <= 0xA1)
>               return type_0xA0[code - 0xA0];

Applied, thanks. As mentioned previously, if you can send me a binary
dump of such a DMI table for my collection, this would be appreciated.

-- 
Jean Delvare
SUSE L3 Support