Re: [PATCH 1/1] dmioem: Decode HPE OEM Record 245

[Jean Delvare]

On Mon, 2023-05-22 at 15:29 -0600, Jerry Hoemann wrote:
> On Sat, May 20, 2023 at 03:33:04PM +0200, Jean Delvare wrote:
> > Hi Jerry,
> > 
> > On Mon, 2023-05-08 at 11:32 -0600, Jerry Hoemann wrote:
> > > Decode HPE OEM Record 245: Extension Board Inventory Record.
> > > 
> > > +       if (data[0x07])
> > > +               pr_attr("CPLD Version", "%c:%x", (data[0x07] >> 7) ? 'B' 
> > > : 'R', (data[0x07] & 0x7F));
> > 
> > Hexadecimal number printed without a prefix can be confusing. Is there
> > any standard regarding how a CPLD version should be presented?
> 
> Oh, I should have put in the leading "0x".
> 
> Don't know about industry standard for displaying CPLD. ProLiant's iLO 
> ineterface
> displays these under "System Progammable Logic Device" and displays the
> version with format 0x%02X.
> 
> This field also has msb denoting an internal release as 'B'.  Customers
> should never see this and the 'R' is normally not displayed as it is
> assumed.  If you want I can tweak the code to only display the 'B' and
> not display the 'R'.

I'm fine either way, so whatever you prefer.

> 
Thanks,
-- 
Jean Delvare
SUSE L3 Support