Re: [PATCH 1/6] dmioem: Update HPE OEM Record 203

[Jean Delvare]

Hi Jerry,

On Thu,  6 Apr 2023 17:38:55 -0600, Jerry Hoemann wrote:
> Add new device locations and flag value.
> 
> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
> ---
>  dmioem.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/dmioem.c b/dmioem.c
> index 4b9248e..46c1142 100644
> --- a/dmioem.c
> +++ b/dmioem.c
> @@ -292,7 +292,13 @@ static void dmi_hp_203_devloc(const char *fname, 
> unsigned int code)
>               "USB",
>               "Dynamic Smart Array Controller",
>               "URL",
> -             "NVMe Drive Bay" /* 0x0F */
> +             "NVMe Drive Bay", /* 0x0F */
> +             "NVDIMM Processor",
> +             "NVDIMM Board",
> +             "NVMe RISER",

Riser isn't an acronym, so would better be written "Riser"?

I can fix it on the fly, no need to resubmit.

> +             "NVDIMM Name Space",
> +             "VROC SATA",
> +             "VROC NVMe", /* 0x15 */
>       };
>  
>       if (code < ARRAY_SIZE(location))
> @@ -869,6 +875,10 @@ static int dmi_decode_hp(const struct dmi_header *h)
>                       }
>                       dmi_hp_203_assoc_hndl("Parent Handle", WORD(data + 
> 0x12));
>                       pr_attr("Flags", "0x%04X", WORD(data + 0x14));
> +                     if (WORD(data + 0x14) & 0x01)
> +                             pr_subattr("Peer Bifurcated Device", "Yes");
> +                     if (WORD(data + 0x14) & 0x02)
> +                             pr_subattr("Upstream Device", "Yes");
>                       dmi_hp_203_devtyp("Device Type", data[0x16]);
>                       dmi_hp_203_devloc("Device Location", data[0x17]);
>                       pr_attr("Device Instance", "%d", data[0x18]);


-- 
Jean Delvare
SUSE L3 Support