Re: [Denemo-devel] Upgrade is missing preferences

[Richard Shann]

On Fri, 2017-09-08 at 19:01 +0200, Johan Vromans wrote:
> On Fri, 08 Sep 2017 17:04:13 +0100, Richard Shann <address@hidden>
> wrote:
> 
> > Ah, right I see. What happens is that Denemo
> > recognizes .denemo-2.1.3-280c7c0 as if it was .denemo-2.1.3 but when it
> > tries to read the file it tries to read .denemo-2.1.3 - it doesn't
> > retain a record of what the file was actually called, but reconstructs
> > it.
> 
> Clear.
> 
> > Question: should Denemo support directories with names other than the
> > ones it generates? That is, Denemo creates .denemo.x.y.z and on the face
> > of it should reject .denemo.x.y.z?*
> 
> First, denemo seems to realise that .denemo-2.1.3-280c7c0 is a settings
> directory, since it offers to import the settings from it. If there are
> several like these, e.g.
> 
>  .denemo-2.1.3-280c7c0
>  .denemo-2.1.3-cd5cf13
>  .denemo-2.1.3-e478167
> 
> Which one should it take? The suffixes are derived from the git commit so
> they have no apparent ordering.

Hopefully, it would not matter too much.

> 
> OTOH, if there's only one, the situation is more straightforward.
> 
> > Is that ok, or is something appending those characters to the directory
> > name (e.g. is something changing the Denemo version from .denemo-2.1.3
> > of the source code as we release it to denemo-2.1.3-280c7c0 for
> > example?)
> 
> The version numbers with git commit ids are something that I create
> manually during the build:
> 
>  git clone git://git.savannah.gnu.org/denemo.git .
>  mv configure.ac configure.ac~
>  sed "s;^\\(AC_INIT(\\[.*\\], \\[\\)\\(.*\\)\\], \\(\\[.*\\])\\);\\1\\2-`git 
> rev-parse --short HEAD`], \\3;" \ <
>  configure.ac~ > configure.ac ./autogen.sh
> 
> So it's probably just me that gets bitten by this. And I have no problem
> changing the most recent one to .denemo-2.1.3 before I do the import...
> 
> TL;DR Don't bother unless you want to.

Well, I have a fix, and I have a feeling that various Distros may do
this sort of tinkering with the cofigure.ac file so if you could test
the fix I'll commit it. Let me know - I have it sitting here right now.

Richard