Re: [Denemo-devel] Integration test for 1.2.2

[Richard Shann]

On Sun, 2015-05-24 at 11:20 +0200, Andreas Schneider wrote:
> Am 23.05.2015 um 22:27 schrieb Richard Shann:
> > That is where I have put it! Second sentence.
> 
> Sorry, I had misunderstood that.
> 
> >> I ran make update-samples and then re-ran the test suite; the results
> >> was that the zoom was changed from 98 to 97. I repeated that procedure
> >> several times, and each time the zoom factor was decreased by 1. So in
> >> the end I was not able get Denemo pass the test.
> > It looks like this is a bug in Denemo, it must be setting the zoom to be
> > one less than the value, so that it will never be right. Well until it
> > reaches 1 I guess...
> > I've put in a fix, and I ran the tests and they passed, so perhaps all
> > will be well now. (Though why they didn't pass for you when they passed
> > for Travis I don't know).
> 
> Looking at the changelog of the official Debian package for Jessie
> (Denemo version 1.1.8), I discovered the following entry:
> 
>   * Patches added in order fix the zoom value in multiple example
>     files. This was causing a failure in the integration tests:
>     - GraceLilyPondBugWorkaround.diff
>     - ChordDiagrams.diff
>     - TemperamentShiftingPlayback.diff
> 
> Those patches are in
> http://http.debian.net/debian/pool/main/d/denemo/denemo_1.1.8-2.debian.tar.xz
> which contains the changes for the Debian version. Did you receive
> feedback about that by the Debian packager?

No, which is a pity as the patches change the zoom level of the
examples, the real fix was to make sure that the zoom stored was
consistently rounded.

Richard