Re: [Denemo-devel] Denemo warnings and code cleanup

[Éloi Rivard]

I pushed a first pass on the master branch. I removed most of unused variable, unused static functions (not in generated files), implicit function declaration, untyped functions and vars warnings, plus some miscellaneous ones.

I didn't touched most of warnings related to gtk deprecation, pointer casting (gpoint to int, int to gpointer), and macros, for the moment.

I commented unused functions, and tagged theme with UNUSED. Could you grep this tag and check if function may be used later, or delete them ?

It would be great to be able to compile with -Werror one day for more safety :)

Another thing, view.c is 11 000 lines long! It is almost 10% of the src directory :) It would be great to split it in several other files. I can take a look, but if would probably be better if you start this, as I don't know the mechanisms behind those 11k lines. What do you think?

2013/5/14 Richard Shann <address@hidden>

On Tue, 2013-05-14 at 11:47 +0200, Éloi Rivard wrote:
> Hi,
>
> Could you have a look at scheme_create_timebase function in view.c.
> The "if" statement emits a warnings, but I don't know how to fix it.
>
> Should it be a double equals operator, or the affectation before the
> "if" statement ?

Good work - it is actually an ! that is missing. I use the idiom
if((a=b)) ... whenever I am tempted to assign and test in one go. I have
fixed this line in git master, thanks for the detective work.

Richard

>
> --
> Éloi Rivard - address@hidden
>
> « On perd plus à être indécis qu'à se tromper. »
>

> _______________________________________________
> Denemo-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/denemo-devel

--
Éloi Rivard - address@hidden
       
« On perd plus à être indécis qu'à se tromper. »