denemo-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Denemo-devel] free g_free in current git


From: Jeremiah Benham
Subject: Re: [Denemo-devel] free g_free in current git
Date: Thu, 19 May 2011 12:07:29 -0500



On May 19, 2011, at 3:07 AM, Richard Shann <address@hidden> wrote:

Jeremiah
@@ -506,6 +516,7 @@ static SCM scheme_activate_menu_item(SCM menupath) {
    item = scm_to_locale_string(menupath);
    if(item) {
      gboolean ret = activate_action(item) ? TRUE:FALSE;
+      g_free(item);
      return SCM_BOOL(ret);
    }
  }

Is this one right? scm_to_locale_string() cannot be returning something allocated with g_malloc can it (since scheme lib knows nothing of glib)?
So it must be malloc, in which case free(item) not g_free()???

Ok. I see i was cinfused because some of these were declared as gchar. Maybe it would be clearer if i have the variables be char instead because the scm_to_locale_string is returning char * and not gchar *.

other examples of the same are further down in this patch...

I don't see any patch.

Jeremiah

Richard



_______________________________________________
Denemo-devel mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/denemo-devel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]