Re: [Denemo-devel] jackmidi check-in

[Jeremiah Benham]

On Mar 31, 2010, at 5:23 AM, Richard Shann <address@hidden>  
wrote:

> Jeremiah - your latest check-in does not call jack_output_midi_event()
> when it is NOTE_OFF. Is that intentional???

I need to look at this again to make sure. I will test it out and push  
something tonight if it needs it.

Jeremiah

> Richard
> this is the diff reported by git:
>
>
> -    if (DP && (si->end_time - event->time_seconds > 0.01)) //Do not
> turn notes on too close to the end
>
> -      jack_output_midi_event(event->midi_buffer, DP->device_number,
> DP->port_number);
>
> +    switch((event->midi_buffer[0] & SYS_EXCLUSIVE_MESSAGE1))
>
> +    {
>
> +      case NOTE_ON: {
>
> +        if (DP && (si->end_time - event->time_seconds > 0.01)) //Do  
> not turn notes on too close to the end
>
> +        jack_output_midi_event(event->midi_buffer, DP- 
> >device_number, DP->port_number);
>
> +      }
>
> +      si->playhead += 0.001;//Make sure playhead is inside duration  
> of note
>
> +      break;
>
> +      case NOTE_OFF:
>
> +       si->playhead -= 0.001;//Make sure playhead is inside  
> duration of note
>
> +       break;
>
> +    }
>
> +
>
>
>
> _______________________________________________
> Denemo-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/denemo-devel