Re: [Denemo-devel] SHOWSTOPPER bug

[Jeremiah Benham]

On Fri, 2009-06-26 at 17:52 +0100, Richard Shann wrote:
> On Fri, 2009-06-26 at 09:09 -0500, Jeremiah Benham wrote:
> > On Fri, 2009-06-26 at 14:30 +0100, Richard Shann wrote:
> > > For directives attached to chords you do not move the cursor:
> > > 
> > >  ;;; piu forte
> > > (d-DirectivePut-chord-override "StepVolume" (logior 
> > > DENEMO_OVERRIDE_VOLUME DENEMO_OVERRIDE_STEP))
> > > (d-DirectivePut-chord-midibytes "StepVolume" "40")
> > > (d-DirectivePut-chord-display "StepVolume" "piu forte")
> > > (d-DirectivePut-chord-postfix "StepVolume" "^\\markup { più \\dynamic f 
> > > }")
> > > (d-RefreshDisplay)
> > > 
> > > I have just coded up the MIDI response to a volume change via a
> > > directive on a chord, as in this example. I think this stuff should
> > > probably go into the release, as such MIDI changes are more naturally
> > > associated with a chord in the score.
> > > 
> > 
> > Are you committing this to stable-0.8.6 and then merging this into
> > master yet? I ask because I have made a simple change I don't know if
> > you want in the release or not. A while back you put some fixes in
> > master. I did not want to push changes into master when it has not been
> > merged into stable-0.8.6. 
> > 
> > The change I made allows the user to set whether they want the object
> > menu minimized on launch. I needed this feature because denemo is too
> > large for my screen and it makes denemo difficult to work with. The
> > default is to display the object menu. If the user does not want to see
> > it on startup they select that in prefs. Then if I need to reference it
> > I just select it in view->.
> > 
> > I will push this if you want it in the release or you have merged
> > stable-0.8.6 with master containing your fixes.
> 
> I have aligned the release and master. I am easy with adding the object
> menu view preference, as we have not actually announced a code freeze.
> Let's agree only showstopper bugfixes onto the 0.8.6 branch from today
> Midnight UTC.


ok. I agree.


> 
> Richard
> 
> 
> 
> > 
> > Jeremiah
> > 
> > 
> >  
> > 
> > 
> > > Richard
> > > 
> > > 
> > > On Fri, 2009-06-26 at 14:24 +0100, Richard Shann wrote:
> > > > Ah, I see. This is not a bug, but a, err, feature. If you are inserting
> > > > a standalone directive amongst other objects then you have to move the
> > > > cursor to the left after you have created it to continue to edit it.
> > > > Thus:
> > > > 
> > > > ;;; piu forte
> > > > (d-DirectivePut-standalone-override "StepVolume" (logior 
> > > > DENEMO_OVERRIDE_VOLUME DENEMO_OVERRIDE_STEP))
> > > > (d-CursorLeft)
> > > > (d-DirectivePut-standalone-midibytes "StepVolume" "40")
> > > > (d-DirectivePut-standalone-display "StepVolume" "piu forte")
> > > > (d-DirectivePut-standalone-postfix "StepVolume" "^\\markup { più 
> > > > \\dynamic f }")
> > > > (d-CursorRight)
> > > > (d-RefreshDisplay)
> > > > 
> > > > Perhaps if we have a (d-DirectivePut-standalone tag) command that just
> > > > creates a directive without setting any fields it should not move the
> > > > cursor? Or perhaps inserting standalone directives should never advance
> > > > the cursor anyway, or perhaps the insertion routine should check the
> > > > previous object to see if it is the Directive being edited...
> > > > 
> > > > Richard
> > > > 
> > > > 
> > > > 
> > > > On Fri, 2009-06-26 at 08:30 +0100, Richard Shann wrote:
> > > > > DenemoDirectives seem to be broken. The following code:
> > > > > 
> > > > > ;;; piu forte
> > > > > (d-DirectivePut-standalone-override "StepVolume" (logior 
> > > > > DENEMO_OVERRIDE_VOLUME DENEMO_OVERRIDE_STEP))
> > > > > (d-DirectivePut-standalone-midibytes "StepVolume" "40")
> > > > > (d-DirectivePut-standalone-display "StepVolume" "piu forte")
> > > > > (d-DirectivePut-standalone-postfix "StepVolume" "^\\markup { più 
> > > > > \\dynamic f }")
> > > > > (d-RefreshDisplay)
> > > > > 
> > > > > Seems to be inserting multiple directives instead of inserting and
> > > > > changing the values in the fields of a single directive.
> > > > > 
> > > > > Can anyone confirm that this is in the current master/0.8.6 candidate?
> > > > > 
> > > > > Richard
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > _______________________________________________
> > > > > Denemo-devel mailing list
> > > > > address@hidden
> > > > > http://lists.gnu.org/mailman/listinfo/denemo-devel
> > > > 
> > > > 
> > > > 
> > > > _______________________________________________
> > > > Denemo-devel mailing list
> > > > address@hidden
> > > > http://lists.gnu.org/mailman/listinfo/denemo-devel
> > > 
> > > 
> > > 
> > > _______________________________________________
> > > Denemo-devel mailing list
> > > address@hidden
> > > http://lists.gnu.org/mailman/listinfo/denemo-devel
> > 
> 
> 
> 
> _______________________________________________
> Denemo-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/denemo-devel