[Dchub-dev] [Patch #1265] bot's global chat & missing library

[nobody]

Patch #1265 has been updated. 

Project: 
Category: None
Status: Open
Summary: bot's global chat & missing library

Follow-Ups:

Date: Thu 03/13/03 at 13:55
By: blusseau

Comment:
What this Patch for ?
-------------------------------------------------------

Date: Thu 03/13/03 at 13:56
By: blusseau

Comment:
What this Patch for ?
-------------------------------------------------------

Date: Thu 03/13/03 at 16:53
By: hhgoth

Comment:
this patch is enabling bot's to send global chat messages, maybe disabled 
accidently before...

the stdlib.c is needed for one free command inside this file - otherwise you'll 
get errormessages when you compile
-------------------------------------------------------

Date: Thu 03/13/03 at 18:09
By: ericprev

Comment:
It was not disabled accidentally, it was removed because there is a bug and it 
is not fixed. With the first level test (the one with the "||(luce->privilege & 
BOT_PRIV)" ), you can enter into the "if" body without a message starting with 
"<nickname> " but the computed value of msg_content always assume the message 
starts with it thus if a bot sends a message like "bouh|" instead of 
"<thebotname> bouh|", str->str[msg_content] is a byte outside the buffer and it 
is technically possible to crash the hub.

The good solution is probably to apply this patch AND to remove the "|| 
(luce->privilege & BOT_PRIV)" of the first "if".
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://savannah.nongnu.org/patch/?func=detailpatch&patch_id=1265&group_id=3963